Use Error exceptions instead of warning in some place in string stdlib #4554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
convert-warnings-to-error-exceptions
branch
from
f5a8027 to
1084c4e
Compare
|
Please use |
nikic
reviewed
Aug 17, 2019
ext/standard/string.c
Outdated
| php_error_docref(NULL, E_WARNING, "Empty needle"); | ||
| RETURN_FALSE; | ||
| zend_throw_exception(zend_ce_error_exception, "Empty needle", E_ERROR); | ||
| return; |
There was a problem hiding this comment.
I think we might be better off removing these errors entirely instead. There is nothing semantically wrong with an empty needle (it'll always match at the first position). It would remove an unnecessary special case.
There was a problem hiding this comment.
Working on it the various implementation of str*pos function family make it a bit awkward to do it in this PR (maybe?). So I will probably do this change separately and try to clean up a bit the implementations.
There was a problem hiding this comment.
Yeah, it would be best to do this in a separate PR.
This was referenced Aug 22, 2019
|
Closing this in favor of the split-off PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted some Warnings to ErrorExceptions, wasn't sure if some of them can/should be converted so I've annotated them.
At the same time split some of the large tests into a variation test for binary tests.