Skip to content

Promote warnings to errors in substr_compare() #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Promote warnings to errors in substr_compare() #4596

wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 22, 2019

Split from #4554

@krakjoe
Copy link
Member

krakjoe commented Aug 29, 2019

There's a todo left in this one ?

@Girgias
Copy link
Member Author

Girgias commented Aug 31, 2019

Merged in as 0240b90

@Girgias Girgias closed this Aug 31, 2019
@Girgias Girgias deleted the substr-compare-warnings2error branch August 31, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Warning promotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Girgias @krakjoe @kocsismate @carusogabriel