Promote warnings to errors in str_word_count() #4604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
approved these changes
Aug 22, 2019
| ?> | ||
| --EXPECTF-- | ||
|
|
||
| DONE |
There was a problem hiding this comment.
Side note: Why are you making this change everywhere? It looks unnecessary.
There was a problem hiding this comment.
I've seen a bunch of test do that in other extensions and else where so I just decided to mimic it for "consistency", I can stop doing that.
There was a problem hiding this comment.
I don't think I've ever seen this. Possibly you saw ===DONE===?
In any case, unless the test output would be empty without it, I don't think there's any point to adding a final "done" in any form.
There was a problem hiding this comment.
Possible yes, Okay will know this for next time :)
|
Merged in as fdff6cf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4554