Promote warnings to errors in str_pad() #4601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Aug 22, 2019
| return; | ||
| } | ||
|
|
||
| num_pad_chars = pad_length - ZSTR_LEN(input); | ||
| if (num_pad_chars >= INT_MAX) { | ||
| php_error_docref(NULL, E_WARNING, "Padding length is too long"); | ||
| zend_throw_error(NULL, "Padding length is too long"); |
There was a problem hiding this comment.
This error condition looks bogus: I see no reason why the number of padding characters should be limited by INT_MAX. Could you submit a separate PR to drop this entirely?
There was a problem hiding this comment.
Sure, maybe something due to before PHP could handle large strings ? (I remember reading something about 2GB string size limit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4554