Skip to content

Promote warnings to errors in chunk_split() #4603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Promote warnings to errors in chunk_split() #4603

wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 22, 2019

Split from #4554

nikic
nikic approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: We should take a look at the error conditions inside php_chunk_split(). They currently result in silent(!) failure :(

@Girgias
Copy link
Member Author

Girgias commented Aug 22, 2019

Side note: We should take a look at the error conditions inside php_chunk_split(). They currently result in silent(!) failure :(

I'll have a look at them

@Girgias
Copy link
Member Author

Girgias commented Aug 22, 2019

Merged in as f51421c

@Girgias Girgias closed this Aug 22, 2019
@Girgias Girgias deleted the chunk-split-warnings2errors branch August 22, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Warning promotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Girgias @nikic @kocsismate