Promote warnings to errors in substr_count() #4605
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhdxr
reviewed
Aug 24, 2019
| @@ -5632,6 +5632,7 @@ PHP_FUNCTION(substr_count) | |||
| length += (haystack_len - offset); | |||
| } | |||
| if (length < 0 || ((size_t)length > (haystack_len - offset))) { | |||
| /* TODO Check if Candidate to convert to Exception */ | |||
| php_error_docref(NULL, E_WARNING, "Invalid length value"); | |||
There was a problem hiding this comment.
why is this warning not converted? invalid length is at least as serious as empty substring IMO.
|
TODO left and questions raised here ... |
|
Merged in as d0754b8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4554