Promote warnings to errors in strpbrk() #4598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Aug 23, 2019
| php_error_docref(NULL, E_WARNING, "The character list cannot be empty"); | ||
| RETURN_FALSE; | ||
| zend_throw_error(NULL, "The character list cannot be empty"); | ||
| return; |
There was a problem hiding this comment.
An alternative here would be to drop the warning instead and return false -- this is consistent with searching for an empty list of characters, which will never be found.
Not sure whether that's actually a good idea though.
There was a problem hiding this comment.
I don't have a strong opinion in this, maybe let internals decide?
|
Should this be converted to an Error or dropped all together? |
|
Ping @nikic, should I bring this up on internals? |
|
@Girgias Let's go with the error for now. LG modulo switch to ValueError. |
Girgias
force-pushed
the
strpbrk-errors2warnings
branch
from
99f15bd to
af929c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4554