Use renderder GitHub pages links #2554
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to #2447 _describe your changes..._ - [ ] Read and sign the [CLA][1]. PRs that haven't signed it won't be accepted. - [ ] Make sure your PR complies with the [writer's guide][2]. - [ ] Review the diff carefully as sometimes this can reveal issues. - __Remove these instructions from your PR as they are for your eyes only.__ [1]: https://cla.js.foundation/webpack/webpack.js.org [2]: https://webpack.js.org/writers-guide/
sorry just a small thing but only just learnt how to add my name to the contribution that I made 2 weeks ago. hope thats ok to add it in here, if not no worries
* docs(guides) updates to code splitting guide * docs(guides) Split chunks link update
added info about a visual tool for creating webpack configs.
* document `optimization.portableRecords` * Fixes #1968 🎉 🎉 🎉
* Update hot-module-replacement.md Simplifying the language * Update hot-module-replacement.md Made changes according to @Legends * Update hot-module-replacement.md
* docs: add ProgressPlugin + progress reporting * Use 4-space indentation
* Update code-splitting.md Since webpack 4, when using `dynamic import` to resolve commonJS module, it no longer resolve directly to the value of `module.exports`, but create an artificial namespace object to wrap it instead. * Update code-splitting.md
This is just a suggestion and needs tweaking, suggestions, additions etc, Just let me know what you guys think and what can be added to it, taken away etc etc. All suggestions extremely welcome. I think this page is necessary and will help a lot but I could be missing something or could have got something wrong as I went through Seans workshops taking notes of what he said. Anyway hope it is at least some what useful
most corrections done from suggestions. More still to be added
all corrections from @montogeek added. Also link to post on live bindings
minor corrections as requested by @EugeneHlushko
added back ticks to require instead of single quotes
modified github user name for contributions as it was incorrect before
added .md extension
updates from comments, minor corrections
final modifications and corrections from review of jeremenichelli
fix travis build as it didnt like the word harder, rephrased to more difficult
Just did a quick check and fixed some minor grammatical errors
added the names of those that I thought helped to bring value to this page
minor changes suggested by @jeremenichelli
removed double title from start
Remove a duplicated sentence.
Readability improvement in a sentence: Before "Now we tell webpack to extract these source maps and into our final bundle:" After "Now we tell webpack to extract these source maps and include in our final bundle:"
* Fixed link to `output` property * Adding the trailing slash for links
…2504) Small updates and corrections for manifest concepts page
* docs(concepts) Update dependency graph concepts page * docs(concepts) Dependency graph minor tweak
#2472) * docs(concepts) use common formatting, provide more links, mention mode in core of the concepts * docs(concepts) duplicate links on the list for better ux * docs(concepts) forgot to add EugeneHlushko to contributors
Update the external docs with an example on how to combine the different syntaxes. I felt it was not clear how to achieve this from the existing docs.
* Update Writing plugin and Plugin pattern page * Fixed formatting issues * Fix markdown lint issues * Update plugin-patterns.md * Update plugin-patterns.md
* Using vendors as entry is not recommended fixes webpack/webpack#6647 * add note about vendor entrypoints
* Correct misspelling and punctuation errors * Update build-performance.md
* docs(config): Example 3 - custom vendor chunk using RegEx * docs(config): Example 3 SplitChunks Fenced blank added * docs(config): (typo) Example 3 - custom vendor chunk using RegEx * sakhisheikh docs(config): (reworded) Example 3 - custom vendor chunk using RegEx * docs(config): (Reword) Example 3 - custom vendor chunk using RegEx * docs(config): (Reword) Example 3 - custom vendor chunk using RegEx
* docs(config): Example 3 - custom vendor chunk using RegEx * squashed everything after c81e77e
This should be updated once webpack/webpack#7947 is released.
* Minor Documentation Clean Up Originally, i was just trying to change defer => differ, but I ended up doing a bit more editing. * Lower the case
Change wording from "bind an extension" to "bind a file extension" in order to distinguish from a webpack extension. _describe your changes..._ - [ ] Read and sign the [CLA][1]. PRs that haven't signed it won't be accepted. - [ ] Make sure your PR complies with the [writer's guide][2]. - [ ] Review the diff carefully as sometimes this can reveal issues. - __Remove these instructions from your PR as they are for your eyes only.__ [1]: https://cla.js.foundation/webpack/webpack.js.org [2]: https://webpack.js.org/writers-guide/
* docs(plugins) scp reuseExistingChunk title nesting fix * docs(plugins) scp reuseExistingChunk title notation
import webpack needs to be highlighted since we are adding webpack.HashedModuleIdsPlugin()
* docs(config) add comments and values for rule.type * updated contributors * fix typo
webpack supports different file types and extensions by default out of the box. `.js`, `.mjs` and `.json` files. but in the old docs, it's been written as it only supports Javascript files.
) * docs(guides): Update example webpack output - the webpack version in the console output is too old (2.6.1) - the console output is too verbose, which doesn't seem to be the default setting * docs(guides): Update example webpack output - the webpack version in the console output is too old (2.6.1) - the console output is too verbose, which doesn't seem to be the default setting
|
Incorrect branching |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2470