Skip to content

Update hot-module-replacement.md #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2018
Merged

Conversation

kryptokinght
Copy link
Contributor

Simplifying the language

Simplifying the language
@@ -13,7 +14,7 @@ Hot Module Replacement (HMR) exchanges, adds, or removes [modules](/concepts/mod

- Retain application state which is lost during a full reload.
- Save valuable development time by only updating what's changed.
- Tweak styling faster -- almost comparable to changing styles in the browser's debugger.
- Live CSS modification -- almost comparable to changing CSS in the browser's debugger.
Copy link
Member

@Legends Legends Aug 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about?:

Modifications made to CSS/JS source code in your IDE result in instant view/browser updates -- almost comparable to changing CSS/JS in the browser's dev tools directly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, that's better. Will apply the changes to the files and commit it again.

Made changes according to @Legends
@kryptokinght
Copy link
Contributor Author

@Legends updated according to your suggestion

@kryptokinght
Copy link
Contributor Author

@montogeek please review this PR

@@ -13,7 +14,7 @@ Hot Module Replacement (HMR) exchanges, adds, or removes [modules](/concepts/mod

- Retain application state which is lost during a full reload.
- Save valuable development time by only updating what's changed.
- Tweak styling faster -- almost comparable to changing styles in the browser's debugger.
- Modifications made to CSS/JS source code in your IDE result in instant view/browser updates -- almost comparable to changing CSS/JS in the browser's dev tools directly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications made to CSS/JS in the source code results in an instant browser update which is almost comparable to changing styles directly in the browser's dev tools.

@kryptokinght
Copy link
Contributor Author

kryptokinght commented Aug 21, 2018

@EugeneHlushko updated according to your suggestion

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@montogeek montogeek merged commit 1c9145c into webpack:master Aug 26, 2018
@montogeek
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants