-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(site): Improve loaders parsing of external link in headers #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this is already changed in |
@budmc29 We are in an effort to modernize this repo infrastructure, our work is in the |
Yes, I can have a look at that, should we close this? |
@montogeek I did a fresh http://localhost:3000/loaders/worker-loader Or is the attached screenshot from a different loader? |
It was the same loader, let me try again |
It was fixed by: #2453, I didn't have latest Although I am not sure if it is good to link the RAW file, it should link to the rendered markdown: What do you think @Munter ? |
@montogeek It does sound like a nicer experience to go the the Github UI for the markdown files. The problem is that the url we get in |
@montogeek I'd like to give it a try and see how it goes, and open another PR. We can close this for now since it's not relevant anymore. Thanks |
Improve the way external links (like licences) in headers are parsed and generated on the website.
Before:

After (the link will act as expected and point the user to the document etc):

This issue is encountered in multiple loaders pages (and possibly in other pages as well), but here's one example:
https://webpack.js.org/loaders/worker-loader/