docs(cli) remove webpack-command #2447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EugeneHlushko
commented
Aug 15, 2018
EugeneHlushko
commented
- remove webpack-command mentions
Legends
reviewed
Aug 16, 2018
There was a problem hiding this comment.
The installation guide states that the user can install either webpack-cli or webpack-command, but what is the difference, which one will be used in the future.
Actually, why two CLI's.
The answer could be added to the installation guide to make it easier for the user which one to choose.
https://webpack.js.org/guides/installation/
|
Actually webpack-command is getting archived and not going to be maintained @Legends |
Legends
approved these changes
Aug 17, 2018
EugeneHlushko
commented
Aug 17, 2018
src/content/guides/installation.md
Outdated
| @@ -34,13 +35,6 @@ If you're using webpack v4 or later, you'll need to install a [CLI](/api/cli/). | |||
| npm install --save-dev webpack-cli | |||
| ``` | |||
|
|
|||
| or | |||
There was a problem hiding this comment.
@Legends i did remove it here 👍
Legends
pushed a commit
to Legends/webpack.js.org
that referenced
this pull request
Aug 18, 2018
In response to webpack#2447
montogeek
pushed a commit
that referenced
this pull request
Aug 20, 2018
In response to #2447 _describe your changes..._ - [ ] Read and sign the [CLA][1]. PRs that haven't signed it won't be accepted. - [ ] Make sure your PR complies with the [writer's guide][2]. - [ ] Review the diff carefully as sometimes this can reveal issues. - __Remove these instructions from your PR as they are for your eyes only.__ [1]: https://cla.js.foundation/webpack/webpack.js.org [2]: https://webpack.js.org/writers-guide/
montogeek
approved these changes
Aug 20, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.