docs(guides) updates to code splitting guide #2427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvdutt
approved these changes
Aug 13, 2018
montogeek
reviewed
Aug 20, 2018
src/content/guides/code-splitting.md
Outdated
| @@ -147,7 +145,7 @@ __webpack.config.js__ | |||
| }; | |||
| ``` | |||
|
|
|||
| With the [`SplitChunks`](/plugins/split-chunks-plugin/) in place, we should now see the duplicate dependency removed from our `index.bundle.js` and `another.bundle.js`. The plugin should notice that we've separated `lodash` out to a separate chunk and remove the dead weight from our main bundle. Let's do an `npm run build` to see if it worked: | |||
| With the [`optimization.SplitChunks`](/configuration/optimization/#optimization-splitchunks) configuration option in place, we should now see the duplicate dependency removed from our `index.bundle.js` and `another.bundle.js`. The plugin should notice that we've separated `lodash` out to a separate chunk and remove the dead weight from our main bundle. Let's do an `npm run build` to see if it worked: | |||
There was a problem hiding this comment.
by the text, With X in place, we should see something removed..., we dont put SplitChunksPlugin in place, we enable it via optimization configuration options...
There was a problem hiding this comment.
So i thought it is clearer to actually show users the configuration option. But your point is very correct in regard of wrong URL, it should be: /plugins/split-chunks-plugin/#optimization-splitchunks and not the optimization page
There was a problem hiding this comment.
there is also a conflict now, need to see what changed and resolve
EugeneHlushko
commented
Aug 20, 2018
| @@ -145,7 +145,7 @@ __webpack.config.js__ | |||
| }; | |||
| ``` | |||
|
|
|||
| With the [`SplitChunks`](/plugins/split-chunks-plugin/) in place, we should now see the duplicate dependency removed from our `index.bundle.js` and `another.bundle.js`. The plugin should notice that we've separated `lodash` out to a separate chunk and remove the dead weight from our main bundle. Let's do an `npm run build` to see if it worked: | |||
| With the [`optimization.splitChunks`](/plugins/split-chunks-plugin/#optimization-splitchunks) configuration option in place, we should now see the duplicate dependency removed from our `index.bundle.js` and `another.bundle.js`. The plugin should notice that we've separated `lodash` out to a separate chunk and remove the dead weight from our main bundle. Let's do an `npm run build` to see if it worked: | |||
There was a problem hiding this comment.
@montogeek updated, also resolved a conflict
EugeneHlushko
commented
Aug 20, 2018
|
|
||
| The [`SplitChunks`](/plugins/split-chunks-plugin/) allows us to extract common dependencies into an existing entry chunk or an entirely new chunk. Let's use this to de-duplicate the `lodash` dependency from the previous example: | ||
| W> The `CommonsChunkPlugin` has been removed in webpack v4 legato. To learn how chunks are treated in the latest version, check out the [`SplitChunksPlugin`](/plugins/split-chunks-plugin/). |
There was a problem hiding this comment.
i've moved this further from header (it was right after Prevent duplication) to be more reader-friendly
montogeek
approved these changes
Aug 20, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplitChunksPluginmentions to correspond to its name and not to configuration option.CommonChunksPluginreference