Patch 1 #8478
Closed
Patch 1 #8478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the master branch. Discussion ---------- Fix a typo Commits ------- f5e9e6b typo
This reverts commit 2d50550.
* 3.4: Updating more types, and basically rewriting the alias article More updating for types typo
* 3.4: (40 commits) Adding an article to explain the 3.3 changes, and how to upgrade updating instance Avoid backticks in shell scripts Update optional_dependencies.rst Fix xml blocks pass only strings to loadUserByUsername() Fix Authenticator Class (getCredentials) example Documented addAnnotatedClassesToCompile() and the use of class patterns Added the picture that shows how GuardAuthenticationListener calls Authentication Guard methods. [symfony#7205] minor tweak Simplified the use of transChoice() [symfony#7875] minor tweaks Minor fix Minor changes Properly show all events and describe guard events [symfony#7891] remove not needed sentence [symfony#7773] fix line length Add helpful remarks on custom DataCollector Remove use of deprecated security.exception_listener.class parameter Update resources.rst ...
* 3.4: tweaks thanks to review Adding second argument to setTrustedProxies() and removing old information replace trusted_proxies reference replace diff code block with PHP code block Remove deprecated trusted_proxies config option Remove deprecated trusted_proxies config option Tweaks after review! Tweaks thanks to Javier's reviews updating example to show class as service id Fixing bad indentation with diff more type changes updating best practices for DI 3.3 changes Minor tweaks for the article that explains the new 3.3 DI features Update some examples using 3.3 features
* 3.4: (27 commits) setfacl commands in the right order add missing options allowed with an env variable [symfony#7941] use class constant Update guard_authentication.rst Fix typo in a class name Fix typo Fixed trivial code example typo Fix typo Fix method reference (`getSubscribedServices()` instead of `getSubscribedEvents()`) Fixed code indentation use Ldap instead of the deprecated LdapClient Fix choice keys and values for custom field types [symfony#7946] fix PHP parameter config example Tiny clarification to Finder component docs [symfony#7917] add LDAP extension link Updated code example for LDAP integration Syntax to create an email Update usage.rst Correct default firewall name on Security docs Fix small typo ...
* 3.4: Encore docs Fixed typo Revert a wrong change from symfony#7877 Remove note about --force option on server:start Small grammatical improvement [DependencyInjection] fix some minor typos remove remaining LdapClient usages add missing XML and PHP config examples explain how to properly override choices Fix custom router loader service declaration
…(pierredup) This PR was merged into the master branch. Discussion ---------- Update example comment to remove unnecessary text Commits ------- bd5d036 Update example comment to remove unnecessary text
* 3.4: Adding missing the Fix autoescape_service example Proofread encore Fixed typo in Encore/Shared-Entry page Add missing argument to code example Fix some typos align travis and platform build environments Fix some typos Adding header to separate sections Adding missing workflow.entered events Create tags.rst Update tags.rst Fixed app/config/services.yml link Minor reword of the intro of the routing/conditions article Minor reword for the intro of the Templating article Fixed indentation in a configuration block Update LessThan.rst "Basic Usage" part Fix typo minor symfony#7999 Small grammatical improvement (catchamonkey) [DI] Automatically applying a tag to all services implementing an interface
* 3.4: removing unnecessary note Re-adding index fixing index problem now that there were *no* frontend articles on 2.7 Removing bower, as even they now recommend to use yarn and webpack [Encore] Fix invalid javascript code Changed link to Capifony cs Fix missing line Update bootstrap.rst resolve_url_loader codeblock did not contain valid javascript Encore tweaks!
… (fbourigault) This PR was merged into the master branch. Discussion ---------- Remove debugging class cache and bootstrap section This remove the no-longer required debugging section about bootstrap file and class cache. Commits ------- 49e24b9 remove debugging class cache and bootstrap section
* 3.4: [symfony#8048] some minor tweaks [symfony#8013] revert wrong data provider change correct PHP code Added a missing <script> tag in an example Fix variable name in CSFR token example code [AUTOWIRE] Fix invalid yaml code clarify workflow events minor tweak Fix comment to be consistent with the example fix invalid code lines and remove extra space Reworded the article about slashes in routing placeholders Minor reword of code contribution standards
* 3.4: Fixes for symfony#8084 thanks to Stof Tweaks thanks to Javier Use Twig's namespaced paths adding anotehr faq for old packages without a main script minor rewording [Encore] Adding more FAQs for symfony#8072 [Encore] Documenting addPlugin - see symfony#8070 Documenting (better) how to expose global variables - see symfony#8071 [Encore] Adding docs about deploying to a subdirectory - see symfony#8069 Adding docs about adding custom config - see symfony#8067 Add missing link to handlebars-loader Add docs for custom loaders [symfony#8004] some minor tweaks document new framework.assets.json_manifest_path option Minor reword Clearify setup of basic auth for test environment Update workflow.rst rearrange how workflow events are presented adding note about extracting CSS Adding note about browserslist config
* 3.4: Replacing EntityManagerInterface -> ->getDoctrine()->getManager(); Adding note about configuring options adding vuejs document
* 3.4: Update custom_constraint.rst [symfony#8087] fix merge Updated language for annouce event Update form best practises regarding Form::isValid Add form_theme in error customization [Routing] is usable without SensioFrameworkBundle since 3.4 Fix typo er(r)or Update questionhelper.rst Typo: lowercase letter Wrap the instantiation in parenthesis, and chain away fix variable being overwritten
* 3.3: incorrect session short description Use of Setters and Getters Small mistype edits Changed text how to get button label Small misspelling fixes Small typo fix Edited to show more ways, to get crawler form Adding FAQ about deploy and git Fix (sense) typo in ACL documentation [Encore] Updating for new sass options ability fixing links in table fixing bad link Adding Assetic versus Encore document
* 3.4: incorrect session short description Use of Setters and Getters Small mistype edits Changed text how to get button label Small misspelling fixes Small typo fix Edited to show more ways, to get crawler form Adding FAQ about deploy and git Fix (sense) typo in ACL documentation [Encore] Updating for new sass options ability fixing links in table fixing bad link Adding Assetic versus Encore document
This PR was merged into the master branch. Discussion ---------- [Stopwatch] Document the reset method Documentation for the new `Stopwatch::reset` method described in symfony/symfony#23284. Commits ------- 4b21133 [Stopwatch] Document the reset method
* 3.4: (23 commits) [symfony#7907] add some use statements Updating Doctrine syntax for getRepository method Reworded the tip about property_info and Symfony framework remove useless space Add information for enable property_info service Updating doctrine class use Fixed the parse() method in the ExpressionLanguage AST examples [symfony#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Updated the screenshot of exceptions in dev environment Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Use "null" so the lock is named automatically Added a help note about translating routes Use a safer code sample for Twig best practices Use the Twig namespaced syntax for all templates Updated the screenshot of deprecation messages ...
…4 (javiereguiluz) This PR was squashed before being merged into the master branch (closes symfony#8135). Discussion ---------- Updated the installation instructions for Symfony 4 It's great to see how simple things are now (for example, there's nothing to say or explain about permissions because you can't have permissions problems when installing Symfony, because of the use of `umask()` by default). Commits ------- 2565b47 Updated the installation instructions for Symfony 4
* 3.4: (31 commits) Revert "[symfony#7939] revert some changes (revert them for 3.2)" [symfony#7939] revert some changes (revert them for 3.2) Minor reword Update twig_reference.rst [symfony#7958] fix minor typo improve examples of how we create test doubles Minor reword Add default indication in input arguments/options description Improved the explanation about deployment + parameters.yml Minor change Add reference to docs in frontend page Add typescript loader documentation Explained how to run tests in multiple kernel apps Fixed the explanation about PHPUnit event listeners in PHPUnitBridge Fix minor typo fixed typo in choice.rst regarding choice_loader File example update [symfony#8003] add XML and PHP config examples Reworded the help note adding note that CSRF protection has to be enabled in config ...
* 3.4: added CVE 2017-11365 added URL where to ask for a CVE identifier add missing choices_as_values options fixing bad diff syntax Update usage.rst
* 3.4: Updated the Core Team information
* 3.4: removed Charles
* 3.4: [symfony#8195] fix requirement checker binary Simplified the requirements article [symfony#6030] Simplifying and showing code Clearify behaviour of Blank and NotBlank validator [symfony#5838] Tweaking comment - the phpdoc policy is not concrete Update standards to match actual practices Updated the Requirements article for Symfony 3.4 Updated the requirements article for Smyfony 3.3 Updated the Requirements article for Symfony 3.2 Updated the Requirements article for Symfony 2.8
…javiereguiluz) This PR was merged into the master branch. Discussion ---------- Updated the Requirements article for Symfony 4.0 This is different from symfony#8142, so it needs a review. Thanks! Commits ------- 0ddc1d6 Updated the Requirements article for Symfony 4.0
* 3.4: (48 commits) [symfony#8192] use path() in PHP templates Reworded the article about form login redirects Update Flex documentation with latest structure Explained the edge-case where the use_referer option doesn't work [symfony#7572] fix wording [symfony#7585] remove trailing whitespaces [symfony#7585] minor rewording Fixed a typo Fixed a typo Update parent_services for tip consistency [symfony#7685] use the method role Minor change Updating doc to specify priority of default normalizer [symfony#7767] remove trailing space [symfony#7767] replace "options" with "entry_options" [symfony#7767] minor rewording [symfony#8047] add inline code comment Fixed the issue in a different way Jquery datePicker syntax update Fix framework instantiation in event-dispatcher ...
* 3.4:
fix option name ("entry_type" instead of "type")
* 3.4: fix referenced target path document
* 3.4: (32 commits) [symfony#8185] minor reword [symfony#8211] minor reword Reword Update language.rst Mention lazy loading for Doctrine event listeners Documented the WebProfilerBundle configuration Added a note about the new behavior of BrowserKit and redirects Fixed usage of default configuration in PHP Some typos Add pipe to dump command Update event_dispatcher.rst Typo fixed in a doctrine docs [symfony#8245] link text directly Link to '"creating a reproducer" in "reporting a bug" Removed an extra line Updated xml config applying comment from @wouterj [Form] [RepeatedType] Update "type" default value Adds a missing semicolon Added missing "," in encore/legacy-apps doc ...
* 3.4: (34 commits) Update resources.rst Update events.rst Improved a help note about authentication providers [symfony#8280] add missing trailing comma [symfony#8282] fix regex delimiters Add missing comment Update parameters.rst validateValue() is deprecated in 3.0 prefer getObject as getEntity is deprecated Fix non-existing Ldap::find() method Fix encore versioning config for SF 4 structure Update serializer.rst [symfony#8308] fix commands order Update NotIdenticalTo.rst Correct psr/log package name Fixed typo Update debugging.rst Update group_service_resolver.rst Update remember_me.rst Update expression_language.rst ...
* 3.4: (42 commits) [symfony#8273] fix bundle registration code [symfony#8273] minor rewording Reworded the built-in web server articles for Symfony 3.3 fix diff code block highlighting [symfony#8269] minor rewording [Console] Commands auto-registration is deprecated [symfony#8231] fix reStructuredText syntax Specified import order of config files [symfony#7981] revert some changes Update upload_file.rst Update usage.rst Update doctrine.rst Update usage.rst [symfony#8260] add missing redirection map entry Delete use_virtuals_forms.rst Added a missing redirection Update validation_group_service_resolver.rst Update redirection_map Update button_based_validation.rst Delete group_service_resolver.rst ...
* 3.4: (46 commits) Minor reword Update deployment.rst Update best_practices.rst Better explain the purpose of the "license" Composer metadata Reverted the changes about bundle namespaces Removed backticks from bundle names add mention of symfony.com re folder structure reword the documentation section re Resources/doc Reverting previous grammar change Removing trailing space Minor changes throughout BP for Reusable Bundles Mention the YAML features not supported by the Yaml component Update storage.rst Moved the commas in the opening paragraph. Adjust .platform.app.yaml from 'symfony' to 'composer' Don't pass .ico through app.php Update shared.rst Update business-logic.rst Update autoload file added a note about bundle inheritance deprecation ...
|
Hi @adouiri! Nice catch & fix!. However, it seems like you edited the text in another branch than you're targetting this PR. Can you please rebase this PR or create a new one with the 3.4 branch as base? If you need any help, feel free to comment and I'll do my best :) |
|
Great! Closing this one in favor of #8479 then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update usage.rst