Skip to content

adding note that CSRF protection has to be enabled in config #8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

JensPliester
Copy link
Contributor

This issue should be mentioned in the guide.
If CSRF Protection is disabled, Symfony won't find the CSRF-Token manager, implicating a missing package.
But all was needed was setting csrf_protection to true in config.yml.

This issue should be mentioned in the guide.
If CSRF Protection is disabled, Symfony won't find the CSRF-Token manager, implicating a missing package.
But all was needed was setting csrf_protection to true in config.yml.
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JensPliester thanks for this! I agree with you and I consider this help note important, so I've reworded it a bit.

@xabbuh xabbuh added this to the 2.7 milestone Jul 9, 2017
@JensPliester
Copy link
Contributor Author

Glad I could help :-)

@xabbuh
Copy link
Member

xabbuh commented Jul 11, 2017

Thank you @JensPliester.

xabbuh added a commit that referenced this pull request Jul 11, 2017
…fig (JensPliester, javiereguiluz)

This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #8003).

Discussion
----------

adding note that CSRF protection has to be enabled in config

This issue should be mentioned in the guide.
If CSRF Protection is disabled, Symfony won't find the CSRF-Token manager, implicating a missing package.
But all was needed was setting csrf_protection to true in config.yml.

Commits
-------

17fdd2e Reworded the help note
b948747 adding note that CSRF protection has to be enabled in config
xabbuh added a commit that referenced this pull request Jul 11, 2017
@xabbuh xabbuh closed this Jul 11, 2017
xabbuh added a commit that referenced this pull request Jul 11, 2017
* 2.7:
  [#7939] revert some changes (revert them for 3.2)
  Minor reword
  Update twig_reference.rst
  [#7958] fix minor typo
  improve examples of how we create test doubles
  Minor reword
  Add default indication in input arguments/options description
  Improved the explanation about deployment + parameters.yml
  Explained how to run tests in multiple kernel apps
  Fixed the explanation about PHPUnit event listeners in PHPUnitBridge
  File example update
  [#8003] add XML and PHP config examples
  Reworded the help note
  adding note that CSRF protection has to be enabled in config
  follow best practices for template files
  Added a note about disabling FastCGI buffering in Nginx
  Add some doc on missing options of framework bundle configuration
  Reworded the explanation about the --router option
xabbuh added a commit that referenced this pull request Jul 11, 2017
* 2.8:
  [#7939] revert some changes (revert them for 3.2)
  Minor reword
  Update twig_reference.rst
  [#7958] fix minor typo
  improve examples of how we create test doubles
  Minor reword
  Add default indication in input arguments/options description
  Improved the explanation about deployment + parameters.yml
  Explained how to run tests in multiple kernel apps
  Fixed the explanation about PHPUnit event listeners in PHPUnitBridge
  File example update
  [#8003] add XML and PHP config examples
  Reworded the help note
  adding note that CSRF protection has to be enabled in config
  follow best practices for template files
  Added a note about disabling FastCGI buffering in Nginx
  Add some doc on missing options of framework bundle configuration
  Reworded the explanation about the --router option
xabbuh added a commit that referenced this pull request Jul 11, 2017
* 3.2:
  Revert "[#7939] revert some changes (revert them for 3.2)"
  [#7939] revert some changes (revert them for 3.2)
  Minor reword
  Update twig_reference.rst
  [#7958] fix minor typo
  improve examples of how we create test doubles
  Minor reword
  Add default indication in input arguments/options description
  Improved the explanation about deployment + parameters.yml
  Explained how to run tests in multiple kernel apps
  Fixed the explanation about PHPUnit event listeners in PHPUnitBridge
  fixed typo in choice.rst regarding choice_loader
  File example update
  [#8003] add XML and PHP config examples
  Reworded the help note
  adding note that CSRF protection has to be enabled in config
  follow best practices for template files
  Added a note about disabling FastCGI buffering in Nginx
  Add some doc on missing options of framework bundle configuration
  Reworded the explanation about the --router option
xabbuh added a commit that referenced this pull request Jul 11, 2017
* 3.3: (31 commits)
  Revert "[#7939] revert some changes (revert them for 3.2)"
  [#7939] revert some changes (revert them for 3.2)
  Minor reword
  Update twig_reference.rst
  [#7958] fix minor typo
  improve examples of how we create test doubles
  Minor reword
  Add default indication in input arguments/options description
  Improved the explanation about deployment + parameters.yml
  Minor change
  Add reference to docs in frontend page
  Add typescript loader documentation
  Explained how to run tests in multiple kernel apps
  Fixed the explanation about PHPUnit event listeners in PHPUnitBridge
  Fix minor typo
  fixed typo in choice.rst regarding choice_loader
  File example update
  [#8003] add XML and PHP config examples
  Reworded the help note
  adding note that CSRF protection has to be enabled in config
  ...
xabbuh added a commit that referenced this pull request Jul 11, 2017
* 3.4: (31 commits)
  Revert "[#7939] revert some changes (revert them for 3.2)"
  [#7939] revert some changes (revert them for 3.2)
  Minor reword
  Update twig_reference.rst
  [#7958] fix minor typo
  improve examples of how we create test doubles
  Minor reword
  Add default indication in input arguments/options description
  Improved the explanation about deployment + parameters.yml
  Minor change
  Add reference to docs in frontend page
  Add typescript loader documentation
  Explained how to run tests in multiple kernel apps
  Fixed the explanation about PHPUnit event listeners in PHPUnitBridge
  Fix minor typo
  fixed typo in choice.rst regarding choice_loader
  File example update
  [#8003] add XML and PHP config examples
  Reworded the help note
  adding note that CSRF protection has to be enabled in config
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants