-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
adding note that CSRF protection has to be enabled in config #8003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue should be mentioned in the guide. If CSRF Protection is disabled, Symfony won't find the CSRF-Token manager, implicating a missing package. But all was needed was setting csrf_protection to true in config.yml.
javiereguiluz
approved these changes
Jul 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JensPliester thanks for this! I agree with you and I consider this help note important, so I've reworded it a bit.
xabbuh
approved these changes
Jul 9, 2017
Glad I could help :-) |
Thank you @JensPliester. |
xabbuh
added a commit
that referenced
this pull request
Jul 11, 2017
…fig (JensPliester, javiereguiluz) This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #8003). Discussion ---------- adding note that CSRF protection has to be enabled in config This issue should be mentioned in the guide. If CSRF Protection is disabled, Symfony won't find the CSRF-Token manager, implicating a missing package. But all was needed was setting csrf_protection to true in config.yml. Commits ------- 17fdd2e Reworded the help note b948747 adding note that CSRF protection has to be enabled in config
xabbuh
added a commit
that referenced
this pull request
Jul 11, 2017
xabbuh
added a commit
that referenced
this pull request
Jul 11, 2017
* 2.7: [#7939] revert some changes (revert them for 3.2) Minor reword Update twig_reference.rst [#7958] fix minor typo improve examples of how we create test doubles Minor reword Add default indication in input arguments/options description Improved the explanation about deployment + parameters.yml Explained how to run tests in multiple kernel apps Fixed the explanation about PHPUnit event listeners in PHPUnitBridge File example update [#8003] add XML and PHP config examples Reworded the help note adding note that CSRF protection has to be enabled in config follow best practices for template files Added a note about disabling FastCGI buffering in Nginx Add some doc on missing options of framework bundle configuration Reworded the explanation about the --router option
xabbuh
added a commit
that referenced
this pull request
Jul 11, 2017
* 2.8: [#7939] revert some changes (revert them for 3.2) Minor reword Update twig_reference.rst [#7958] fix minor typo improve examples of how we create test doubles Minor reword Add default indication in input arguments/options description Improved the explanation about deployment + parameters.yml Explained how to run tests in multiple kernel apps Fixed the explanation about PHPUnit event listeners in PHPUnitBridge File example update [#8003] add XML and PHP config examples Reworded the help note adding note that CSRF protection has to be enabled in config follow best practices for template files Added a note about disabling FastCGI buffering in Nginx Add some doc on missing options of framework bundle configuration Reworded the explanation about the --router option
xabbuh
added a commit
that referenced
this pull request
Jul 11, 2017
* 3.2: Revert "[#7939] revert some changes (revert them for 3.2)" [#7939] revert some changes (revert them for 3.2) Minor reword Update twig_reference.rst [#7958] fix minor typo improve examples of how we create test doubles Minor reword Add default indication in input arguments/options description Improved the explanation about deployment + parameters.yml Explained how to run tests in multiple kernel apps Fixed the explanation about PHPUnit event listeners in PHPUnitBridge fixed typo in choice.rst regarding choice_loader File example update [#8003] add XML and PHP config examples Reworded the help note adding note that CSRF protection has to be enabled in config follow best practices for template files Added a note about disabling FastCGI buffering in Nginx Add some doc on missing options of framework bundle configuration Reworded the explanation about the --router option
xabbuh
added a commit
that referenced
this pull request
Jul 11, 2017
* 3.3: (31 commits) Revert "[#7939] revert some changes (revert them for 3.2)" [#7939] revert some changes (revert them for 3.2) Minor reword Update twig_reference.rst [#7958] fix minor typo improve examples of how we create test doubles Minor reword Add default indication in input arguments/options description Improved the explanation about deployment + parameters.yml Minor change Add reference to docs in frontend page Add typescript loader documentation Explained how to run tests in multiple kernel apps Fixed the explanation about PHPUnit event listeners in PHPUnitBridge Fix minor typo fixed typo in choice.rst regarding choice_loader File example update [#8003] add XML and PHP config examples Reworded the help note adding note that CSRF protection has to be enabled in config ...
xabbuh
added a commit
that referenced
this pull request
Jul 11, 2017
* 3.4: (31 commits) Revert "[#7939] revert some changes (revert them for 3.2)" [#7939] revert some changes (revert them for 3.2) Minor reword Update twig_reference.rst [#7958] fix minor typo improve examples of how we create test doubles Minor reword Add default indication in input arguments/options description Improved the explanation about deployment + parameters.yml Minor change Add reference to docs in frontend page Add typescript loader documentation Explained how to run tests in multiple kernel apps Fixed the explanation about PHPUnit event listeners in PHPUnitBridge Fix minor typo fixed typo in choice.rst regarding choice_loader File example update [#8003] add XML and PHP config examples Reworded the help note adding note that CSRF protection has to be enabled in config ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue should be mentioned in the guide.
If CSRF Protection is disabled, Symfony won't find the CSRF-Token manager, implicating a missing package.
But all was needed was setting csrf_protection to true in config.yml.