Explained the locateResource() method of HttpKernel #7909
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilhemN
reviewed
May 17, 2017
bundles/best_practices.rst
Outdated
| files, etc.), don't use physical paths (e.g. ``__DIR__/config/services.xml``) | ||
| but logical paths (e.g. ``@AppBundle/Resources/config/services.xml``). | ||
|
|
||
| The logical paths are required beucase of the bundle overriding mechanism that |
xabbuh
requested changes
May 25, 2017
bundles/best_practices.rst
Outdated
| Resources | ||
| --------- | ||
|
|
||
| If the bundle references any resources (config files, templates, translation |
There was a problem hiding this comment.
The notation explained here does not work for Twig templates.
There was a problem hiding this comment.
I'm afraid I don't understand your comment.
There was a problem hiding this comment.
For Twig templates the namespace would be @App instead of @AppBundle. And furthermore, you would leave out the Resources/views portion of the template path (because Twig namespaces are not handled by the kernel resource locater but are a core feature of Twig itself).
There was a problem hiding this comment.
I've reworded this. I truly dislike that the logical path of templates is different than for the rest of resources. I understand that "old Symfony" used bundles everywhere and @App/Default/index.html.twig was more convenient than @AppBundle/Resources/views/Default/index.html.twig.
However, for Symfony 4 / Flex, which removes the concept of bundles for your own code, I think we should remove this difference and use the same syntax for everything.
xabbuh
reviewed
Jul 6, 2017
| lets you override any resource/file of any bundle. See :ref:`http-kernel-resource-locator` | ||
| for more details about transforming physical paths into logical paths. | ||
|
|
||
| Beware that templates use a simplified version of the logical path showed above. |
xabbuh
reviewed
Jul 6, 2017
| for more details about transforming physical paths into logical paths. | ||
|
|
||
| Beware that templates use a simplified version of the logical path showed above. | ||
| For example, a ``index.html.twig`` template located in the ``Resources/views/Default/`` |
xabbuh
approved these changes
Jul 6, 2017
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Jul 7, 2017
…ereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #7909). Discussion ---------- Explained the locateResource() method of HttpKernel This fixes #4065 and replaces #7479, which didn't explain the method inside the HttpKernel component docs. Commits ------- b46ff01 Explained the locateResource() method of HttpKernel
xabbuh
added a commit
that referenced
this pull request
Jul 7, 2017
* 2.7: [#7907] add some use statements Updating Doctrine syntax for getRepository method Updating doctrine class use [#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Added a help note about translating routes Use a safer code sample for Twig best practices Use the Twig namespaced syntax for all templates
xabbuh
added a commit
that referenced
this pull request
Jul 9, 2017
* 2.8: [#7907] add some use statements Updating Doctrine syntax for getRepository method Reworded the tip about property_info and Symfony framework remove useless space Add information for enable property_info service Updating doctrine class use [#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Added a help note about translating routes Use a safer code sample for Twig best practices Use the Twig namespaced syntax for all templates Updated the screenshot of deprecation messages
xabbuh
added a commit
that referenced
this pull request
Jul 9, 2017
* 3.2: [#7907] add some use statements Updating Doctrine syntax for getRepository method Reworded the tip about property_info and Symfony framework remove useless space Add information for enable property_info service Updating doctrine class use Fixed the parse() method in the ExpressionLanguage AST examples [#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Use "null" so the lock is named automatically Added a help note about translating routes Use a safer code sample for Twig best practices Use the Twig namespaced syntax for all templates Updated the screenshot of deprecation messages Update lockable_trait.rst
xabbuh
added a commit
that referenced
this pull request
Jul 9, 2017
* 3.3: (36 commits) [#7907] add some use statements Updating Doctrine syntax for getRepository method Reworded the tip about property_info and Symfony framework remove useless space Add information for enable property_info service Updating doctrine class use Fixed the parse() method in the ExpressionLanguage AST examples [#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Updated the screenshot of exceptions in dev environment Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Use "null" so the lock is named automatically incorrect session short description Use of Setters and Getters Small mistype edits Changed text how to get button label ...
xabbuh
added a commit
that referenced
this pull request
Jul 9, 2017
* 3.4: (23 commits) [#7907] add some use statements Updating Doctrine syntax for getRepository method Reworded the tip about property_info and Symfony framework remove useless space Add information for enable property_info service Updating doctrine class use Fixed the parse() method in the ExpressionLanguage AST examples [#7909] fix some typos Explained the locateResource() method of HttpKernel Reworded the note about dump() not being available in prod Symfony Installer Instructions for Windows Updated the screenshot of exceptions in dev environment Typo Fixing a typo in the Final Thoughts section Stop recommending the use of "doctrine:generate:entities" Use "null" so the lock is named automatically Added a help note about translating routes Use a safer code sample for Twig best practices Use the Twig namespaced syntax for all templates Updated the screenshot of deprecation messages ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4065 and replaces #7479, which didn't explain the method inside the HttpKernel component docs.