Skip to content

[Stopwatch] Document the reset method #8082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

jmgq
Copy link
Contributor

@jmgq jmgq commented Jun 24, 2017

Documentation for the new Stopwatch::reset method described in symfony/symfony#23284.

@xabbuh xabbuh added the On hold label Jul 1, 2017
fabpot added a commit to symfony/symfony that referenced this pull request Jul 3, 2017
This PR was merged into the 3.4 branch.

Discussion
----------

[Stopwatch] Add a reset method

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23284
| License       | MIT
| Doc PR        | symfony/symfony-docs#8082

Let the Stopwatch to be reset to its original state, deleting all the data measured so far. This allows the stopwatch to be reusable, and emulates an actual stopwatch's reset button.

Commits
-------

7cda099 [Stopwatch] Add a reset method
@xabbuh xabbuh added this to the 3.4 milestone Jul 3, 2017
@xabbuh xabbuh removed the On hold label Jul 3, 2017
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmgq thanks for implementing this feature and for documenting it.

@xabbuh
Copy link
Member

xabbuh commented Jul 7, 2017

Thank you @jmgq.

@xabbuh xabbuh merged commit 4b21133 into symfony:master Jul 7, 2017
xabbuh added a commit that referenced this pull request Jul 7, 2017
This PR was merged into the master branch.

Discussion
----------

[Stopwatch] Document the reset method

Documentation for the new `Stopwatch::reset` method described in symfony/symfony#23284.

Commits
-------

4b21133 [Stopwatch] Document the reset method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants