Update some examples using 3.3 features #7877

GuilhemN · 2017-05-05T22:28:33Z

I updated some examples using 3.3 di features, but there is still a lot to do.

xabbuh · 2017-05-12T09:49:23Z

best_practices/templates.rst

+
+        # add Service/ to the list of directories to load services from
+        AppBundle\:
+            resource: '../../src/AppBundle/{Service,Updates,Command,Form,EventSubscriber,Twig,Security}'


the Updates namespace looks wrong to me

Indeed, good catch!

xabbuh · 2017-05-12T09:50:43Z

form/create_custom_field_type.rst

        services:
-            app.form.type.gender:
-                class: AppBundle\Form\Type\GenderType
+            AppBundle\Form\Type\GenderType:
                arguments:
                    - '%genders%'
                tags: [form.type]


What about using autoconfigure instead?

same in other places

In fact, imo we should assert that the user has the default SE config and remove config blocks when they're useless. We could just add a note to explain how to declare services manually once for each feature.
Wdyt?

Sounds good

GuilhemN · 2017-05-12T16:59:13Z

I think I'll split this PR in smaller PRs like #7902 because it's much longer to respect #7877 (comment).

weaverryan · 2017-05-16T10:49:14Z

I updated some examples using 3.3 di features, but there is still a lot to do.

@GuilhemN In fact, I apologize, because I'm completely running over your work :/. There are just so many entries to update, that I've been keeping a list locally and running through them (and making GIANT PRs). That's not idea, but I don't think we'll be able to update everything in time without doing that. However, that does mean that those PR's need review (and also, possible some of the most important docs could/should be proofread afterwards ).

However, you do have a few entires I don't. Could you rebase? So far, I'm skipping the following directories and saving for later:

best_practices
bundles
components
console
create_framework
reference

Thanks!

This PR was merged into the master branch. Discussion ---------- Update best_practices/templates.rst First example of a doc asserting we're using the 3.3 SE (#7877 (comment)). Commits ------- 8769a30 Update best_practices/templates.rst

GuilhemN · 2017-05-16T15:10:55Z

@GuilhemN In fact, I apologize, because I'm completely running over your work :/. There are just so many entries to update, that I've been keeping a list locally and running through them (and making GIANT PRs).

No problem, this PR didn't take me long to do :)

Could you rebase?

done ;)

Do you still need help for the remaining parts?

xabbuh · 2017-05-17T08:22:02Z

form/type_guesser.rst

-            <services>
+            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+            xsi:schemaLocation="http://symfony.com/schema/dic/services
+                http://symfony.com/schema/dic/services/services-1.0.xsd">


this change should probably also be made on older branches

done in #7915, I also found many others...

xabbuh · 2017-05-17T08:24:18Z

reference/dic_tags.rst

@@ -886,8 +862,7 @@ of your configuration and tag it with ``routing.loader``:
    .. code-block:: yaml

        services:
-            app.custom_routing_loader:
-                class: AppBundle\Routing\CustomLoader
+            AppBundle\Routing\CustomLoader:
                tags: [routing.loader]


could be merged with the previous line

xabbuh · 2017-05-17T08:24:33Z

reference/dic_tags.rst

@@ -763,8 +745,7 @@ You can add a processor globally:
    .. code-block:: yaml

        services:
-            my_service:
-                class: Monolog\Processor\IntrospectionProcessor
+            Monolog\Processor\IntrospectionProcessor:
                tags: [monolog.processor]


could be merged with the previous line

xabbuh · 2017-05-17T08:24:47Z

reference/dic_tags.rst

@@ -636,8 +627,7 @@ configuration and tag it with ``kernel.event_subscriber``:
    .. code-block:: yaml

        services:
-            app.custom_subscriber:
-                class: AppBundle\EventListener\CustomSubscriber
+            AppBundle\EventListener\CustomSubscriber:
                tags: [kernel.event_subscriber]


could be merged with the previous line

indeed, done

xabbuh · 2017-05-19T14:06:49Z

@GuilhemN Can you resolve the conflicts? :)

GuilhemN · 2017-05-19T15:57:34Z

@xabbuh done

weaverryan · 2017-05-21T15:14:02Z

Thanks @GuilhemN!

This PR was merged into the 3.3 branch. Discussion ---------- Update some examples using 3.3 features I updated some examples using 3.3 di features, but there is still a lot to do. Commits ------- 04903f7 Update some examples using 3.3 features

This PR was merged into the 3.3 branch. Discussion ---------- Revert a wrong change from #7877 As spotted by #7978, the short service syntax is about arguments and not tags, so this change was wrong. Commits ------- f3b1112 Revert a wrong change from #7877

* 3.4: Encore docs Fixed typo Revert a wrong change from #7877 Remove note about --force option on server:start Small grammatical improvement [DependencyInjection] fix some minor typos remove remaining LdapClient usages add missing XML and PHP config examples explain how to properly override choices Fix custom router loader service declaration

carsonbot added the Status: Needs Review label May 5, 2017

GuilhemN force-pushed the DI branch 3 times, most recently from 0839806 to 5fc9ffe Compare May 8, 2017 12:41

xabbuh reviewed May 12, 2017

View reviewed changes

GuilhemN force-pushed the DI branch from 5fc9ffe to b07c2b7 Compare May 12, 2017 15:59

GuilhemN mentioned this pull request May 12, 2017

Update best_practices/templates.rst #7902

Merged

GuilhemN force-pushed the DI branch from 24d4d14 to 5f4ab4b Compare May 16, 2017 15:08

xabbuh reviewed May 17, 2017

View reviewed changes

xabbuh approved these changes May 17, 2017

View reviewed changes

xabbuh added Status: Reviewed and removed Status: Needs Review labels May 17, 2017

GuilhemN force-pushed the DI branch 2 times, most recently from de69532 to 14b4689 Compare May 18, 2017 16:38

GuilhemN changed the base branch from master to 3.3 May 19, 2017 15:55

Update some examples using 3.3 features

04903f7

GuilhemN force-pushed the DI branch from 14b4689 to 04903f7 Compare May 19, 2017 15:57

weaverryan merged commit 04903f7 into symfony:3.3 May 21, 2017

GuilhemN deleted the DI branch May 21, 2017 15:50

GuilhemN added a commit to GuilhemN/symfony-docs that referenced this pull request Jun 8, 2017

Revert a wrong change from symfony#7877

f3b1112

michaelperrin pushed a commit to michaelperrin/symfony-docs that referenced this pull request Nov 18, 2017

Revert a wrong change from symfony#7877

429cd5b

Uh oh!

Update some examples using 3.3 features #7877

Update some examples using 3.3 features #7877

Uh oh!

Conversation

GuilhemN commented May 5, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuilhemN May 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuilhemN commented May 12, 2017

Uh oh!

weaverryan commented May 16, 2017

Uh oh!

GuilhemN commented May 16, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuilhemN May 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xabbuh commented May 19, 2017

Uh oh!

GuilhemN commented May 19, 2017

Uh oh!

weaverryan commented May 21, 2017

Uh oh!

Uh oh!

GuilhemN May 12, 2017 •

edited

Loading

GuilhemN May 17, 2017 •

edited

Loading