Consistent named param: Extension Tracker

[Girgias]

This is a tracker to see which extensions have been reviewed in regards to #16

• BCMath (Update gmp+bcmath parameter names php-src#6205)
• BZ2 (Update ext/bz2 parameter names php-src#6280)
• Calendar (Update ext/calendar parameter names php-src#6277)
• COM (Update ext/com_dotnet parameter names php-src#6296)
• Ctype (Improve argument types and names in ext/ctype php-src#5878)
• cURL (Improve parameter names in ext/curl php-src#6155)
• Date
• DBA (Update ext/dba parameter names php-src#6292)
• DOM (Consolidate XML api parameter names php-src#5893)
• Enchant (Review parameter names in ext/enchant php-src#6258)
• Exif (Review parameter names in ext/exif php-src#6256)
• FFI (Update ext/ffi parameter names php-src#6282)
• FileInfo (Update fileinfo names php-src#6206)
• Filter (Rename a few parameters in ext/filter php-src#6229)
• FTP (Review parameter names in ext/ftp php-src#6254)
• GD (Update ext/gd parameter names php-src#6308)
• GetText (Review parameter names in ext/gettext php-src#6241)
• GMP (Update gmp+bcmath parameter names php-src#6205)
• Hash (Improve parameter names in ext/hash php-src#6156)
• Iconv (Update iconv names php-src#6234)
• IMAP (Update ext/imap parameter names php-src#6299)
• Intl (Improve parameter names in ext/intl php-src#6309)
• JSON (Review parameter names in ext/json php-src#6236)
• LDAP (ext/ldap parameter fixes php-src#6153)
• libxml
• MBString (Standardize mbstring and string on using 'string' as a parameter name. php-src#6171, Update mbstring parameter names php-src#6207)
• MySQLi (Rename mysqli parameters to be more logical. php-src#6172)
• OCI8 (Improve parameter names in ext/oci8 php-src#6267)
• ODBC (Update ext/odbc parameter names php-src#6303)
• OpCache (Review parameter names in ext/opcache php-src#6237)
• OpenSSL (Improve parameter handling in ext/openssl php-src#6025, Adjust ext/openssl parameter names php-src#6121)
• PCNTL (Update ext/pcntl parameter names php-src#6278)
• PCRE (Review parameter names in ext/pcre php-src#6259)
• PDO (Rename PDO parameters. php-src#6220, Update PDO parameter names php-src#6272)
• PDO_SQLite (Improve parameter names in ext/pdo_sqlite php-src#6310)
• PDO_PGSql (Update ext/pdo_pgsql parameter names php-src#6329)
• PGSQL (Update ext/pgsql parameter names php-src#6294, Update PostgreSQL parameters php-src#6304)
• Phar (Update ext/phar parameter names php-src#6307)
• POSIX (Update ext/posix parameter names php-src#6275)
• PSpell (Review parameter names in ext/pspell php-src#6257)
• Readline (Review parameter names in ext/readline php-src#6240)
• Reflection (Cleanup argument handling in ext/reflection php-src#5850, Reflection param renames amendment php-src#6230)
• Session (Review parameter names in ext/session php-src#6239)
• SHMOP (Review parameter names in ext/shmop php-src#6238)
• SimpleXML (Consolidate XML api parameter names php-src#5893)
• SNMP (Update ext/snmp parameter names php-src#6298)
• SOAP (Update ext/soap parameter names php-src#6300)
• Sockets (Update ext/sockets parameter names php-src#6276)
• Sodium (Update ext/sodium parameter names php-src#6279)
• SPL (Update ext/spl parameter names php-src#6284)
• SQLite3 (Renaming parameter names in ext/sqlite3 php-src#6264)
• Standard (Clean up array function signatures for named parameters php-src#6046, Update ext/standard parameter names php-src#6214)
• SysVMsg (Review parameter names in ext/sysvmsg php-src#6247)
• SysVSem (Review parameter names in ext/sysvsem php-src#6248)
• SysVShm (Review parameter names in ext/sysvshm php-src#6249)
• Tidy (Update ext/tidy parameter names php-src#6283)
• Tokenizer (Update ext/tokenizer param names php-src#6232)
• XML (Update ext/xml parameter names php-src#6297)
• XMLReader (Review parameter names in ext/xmlreader php-src#6255)
• XMLWriter (Improve parameter names in ext/xmlwriter php-src#6202)
• XSL (Update ext/xsl parameter names php-src#6295)
• ZIP (php/php-src@dafc72c)
• ZLIB (Review parameter names in ext/zlib php-src#6250)
• Zend/ (Cleanup argument handling of Zend functions and methods php-src#5847, Zend parameter renames amendment php-src#6228)

Unresolved questions:

• Update ext/standard parameter names php-src#6214 (comment) and following

[remicollet]

Checked zip, consistency fixed in php/php-src@dafc72c

[remicollet]

As a side note, this also means php documentation probably needs a big update, so the parameters name describe there matches actual one in 8

Done for zip in php/doc-en@462e369 and php/doc-en@002b7dd

[kocsismate]

@remicollet Yes, we have already started working on (at least making it possible to) automatically generate function signatures for the manual.

And later we should change the parameter names in the descriptions as well.

[cmb69]

And later we should change the parameter names in the descriptions as well.

That should be done as soon as the signatures are changed in the manual. :)

[kocsismate]

That should be done as soon as the signatures are changed in the manual. :)

True :) I messed up the timeline ^^ Should have said "afterwards" or "right after"

[dtakken]

Related PR to update the coding standards to include parameter names:

php/php-src/pull/5897

[Crell]

PR for pgsql: php/php-src#6304

Waiting to see if it passes tests... 😅

[nikic]

I believe we're done here.