Skip to content

Improve parameter names in ext/intl #6309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Improve parameter names in ext/intl #6309

wants to merge 5 commits into from

Conversation

kocsismate
Copy link
Member

No description provided.

kocsismate
kocsismate commented Oct 9, 2020
View reviewed changes
@nikic nikic mentioned this pull request Oct 9, 2020
Closed
65 tasks
nikic
nikic reviewed Oct 9, 2020
View reviewed changes
nikic
nikic reviewed Oct 11, 2020
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me, but I noticed that there are some discrepancies between the procedural and OO APIs. E.g intlcal_before uses $other while IntlCalendar::before() uses $calendar. I think we should be keeping these consistent.

nikic
nikic approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@php-pulls php-pulls closed this in 186612e Oct 12, 2020
@kocsismate kocsismate deleted the intl-names branch October 12, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Parameter names
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @nikic