Reflection param renames amendment #6230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Sep 28, 2020
| @@ -254,16 +254,16 @@ public function hasProperty(string $name) {} | |||
| public function getProperty(string $name) {} | |||
|
|
|||
| /** @return ReflectionProperty[] */ | |||
| public function getProperties(?int $filter = null) {} | |||
| public function getProperties(?int $modifiers = null) {} | |||
There was a problem hiding this comment.
Other possibilities: $filtered_modifiers, $only_modifiers
There was a problem hiding this comment.
$rc->getProperties(filter: ReflectionProperty::IS_PUBLIC);
$rc->getProperties(only: ReflectionProperty::IS_PUBLIC);
$rc->getProperties(modifiers: ReflectionProperty::IS_PUBLIC);
$rc->getProperties(filter_modifiers: ReflectionProperty::IS_PUBLIC);
$rc->getProperties(only_modifiers: ReflectionProperty::IS_PUBLIC);
Hm ... my preference would go to the original $filter followed by $filter_modifiers.
There was a problem hiding this comment.
I have no hard feelings about any of the names :) So I'm changing this.
65 tasks
kocsismate
force-pushed
the
reflection-amendment
branch
from
bd819e6 to
2ef0f02
Compare
kocsismate
commented
Sep 29, 2020
|
|
||
| if (zend_parse_parameters(ZEND_NUM_ARGS(), "|l", &filter) == FAILURE) { | ||
| if (zend_parse_parameters(ZEND_NUM_ARGS(), "|l!", &filter, &filter_is_null) == FAILURE) { |
There was a problem hiding this comment.
I made these params nullable because the previous default value was horrible, there were precedents for doing so before (e.g. ReflectionClass:getMethods())
kocsismate
force-pushed
the
reflection-amendment
branch
from
2ef0f02 to
5ed837c
Compare
nikic
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.