Skip to content

Update ext/pgsql parameter names #6294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

nikic
Copy link
Member

@nikic nikic commented Oct 7, 2020

Because of how pervasive it is in the API, I retained the $field terminology (rather than $column).

Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to get rid of the $stmt names here? I think we only use it in ext/mysqli, and nowhere else.

@kocsismate
Copy link
Member

And what's your stance on renaming the stmt parameters? Or do you want them to be consistent with mysqli?

@nikic
Copy link
Member Author

nikic commented Oct 13, 2020

And what's your stance on renaming the stmt parameters? Or do you want them to be consistent with mysqli?

I've switched things to use $statement_name now.

@php-pulls php-pulls closed this in 3171fec Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants