Cleanup argument handling of Zend functions and methods #5847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Jul 12, 2020
kocsismate
force-pushed
the
argument-handling-zend
branch
2 times, most recently
from
db5f85e to
1555411
Compare
kocsismate
commented
Jul 12, 2020
nikic
reviewed
Jul 14, 2020
nikic
reviewed
Jul 14, 2020
kocsismate
force-pushed
the
argument-handling-zend
branch
from
1555411 to
d3a3e1a
Compare
nikic
reviewed
Jul 15, 2020
nikic
reviewed
Jul 15, 2020
nikic
reviewed
Jul 15, 2020
nikic
reviewed
Jul 15, 2020
kocsismate
force-pushed
the
argument-handling-zend
branch
from
d3a3e1a to
9ae0493
Compare
nikic
reviewed
Jul 21, 2020
nikic
approved these changes
Jul 21, 2020
kocsismate
force-pushed
the
argument-handling-zend
branch
from
9ae0493 to
0511bdf
Compare
kocsismate
force-pushed
the
argument-handling-zend
branch
from
0511bdf to
1281c59
Compare
65 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNKNOWNdefault valueAdditionally, I removed the$non_csparameter ofdefine(), but actually, I wasn't sure it's really the right time to do it.