Skip to content

release 4.1.0 -> master #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Nov 10, 2021
Merged

release 4.1.0 -> master #51

merged 57 commits into from
Nov 10, 2021

Conversation

HappyZombies
Copy link
Member

Summary 📖

This PR merges the changes from development into master.

jankapunkt and others added 30 commits October 10, 2021 14:36
@jankapunkt
added test coverage using nyc
17e2729
@jankapunkt
Create tests.yml
a88bb4d
@jankapunkt
uncomment line for coverage test until cov is added
917b4b9
@jankapunkt
ci change push branch dev to development
dcd8a3d
@HappyZombies
Merge pull request #14 from node-oauth/add-ci
cf1ab06 
Add CI
@HappyZombies
Merge pull request #13 from node-oauth/test-coverage
b7b8af6 
added test coverage using nyc
@jankapunkt
docs: added contribution guide draft
4a9eb7b
@HappyZombies
Remove statuses, use http.STATUS_CODES
534b5e7
@jankapunkt
updated development guidelines
1722039
@jankapunkt
contribution guidelines added guiding principles
6a0c93c
@jankapunkt
pull request template added
c833a37
@jankapunkt
docs removed maintainers section from contribution guide
de41dc7
@HappyZombies
Merge pull request #26 from node-oauth/feature.http-status
4d893e4 
Remove statuses package, use built in http.STATUS_CODES
@jwerre
removed jshint added eslint
e650264
@jwerre
merge with development branch
9ebf817
@jwerre
removed should added chai
18d2404
@jwerre
removed some log statements
05b8944
@jwerre
removed 'no-prototype-builtins' from eslint
0cf3b11
@oklas
docs: add commit message convention and coding rules
ca47721
@jankapunkt
tests validator is tested for all unicode ranges
b4e344d
@jankapunkt
validator is add missing variable in is.uchar
f57f4c3
@jankapunkt
tests validator also test for multiple characters
615bd75
@jankapunkt
eslint enable no-control-regex and disable only in validator
c0e4ef1
@jankapunkt
tests validator is increase timeout
9775b39
@oklas
docs: lightly softify commit convention requirements
60bad87
@HappyZombies
refactor: update mocha to latest version #17
5a98700
@jwerre
removed tab in token-model_test.js
4003209
@HappyZombies
Merge pull request #29 from node-oauth/chai
a6c257f 
Replace exception library Should with Chai
@jwerre
added chai to is_test.js
391fbef
@jwerre
removed jshint
2e4d14f
HappyZombies and others added 19 commits October 13, 2021 11:08
@HappyZombies
Merge pull request #30 from node-oauth/lint
c0196f3 
Replaces jshint with eslint
@jwerre
resolved package conflicts
79bcb7c
@HappyZombies
Merge pull request #33 from node-oauth/feature.update-mocha
8bb0dcc 
Bump mocha from 5.2.0 to 9.1.2
@jankapunkt
docs: correct types and available scripts and add info about removing…
4985ca7 
… branch
@jankapunkt
docs: add pull request template
fcec276
@HappyZombies
Merge pull request #18 from node-oauth/contribution-guidelines
3dc2f6d 
Contribution guidelines
@HappyZombies
test: Update sinon to latest version #17
0d3f621
@HappyZombies
Merge pull request #39 from node-oauth/feature.sinon-update
b1676fb
@jankapunkt
build(packaging): update minimal supported node version to 12 #34
f8c398f
@jankapunkt
fix(security): use sha256 for token generation #38
769878d
@HappyZombies
Merge pull request #41 from node-oauth/update-node-version
26b3eb3 
update minimal supported node version to 12
@HappyZombies
Merge pull request #43 from node-oauth/fix-sha1-to-sha256
ff6a450 
use sha256 for token generation
@jorenvandeweyer
Remove lodash dependency (#37)
8e05cb5 
refactor: remove lodash dependency #23
@jankapunkt
ci(dev-infra): add codeql semantic analysis #16 #36
156b34f
@jankapunkt
ci(dev-infra): make codeql scane on push and pr equal #16 #36
be8121b
@HappyZombies
refactor:Fix typos and clean up package.json and package-lock.json
100e8ae
@HappyZombies
Merge pull request #46 from node-oauth/feature.small-cleanup
ffb28c3
@HappyZombies
Merge pull request #45 from node-oauth/feature-ci-static-semantic-ana…
cfa907d 
…lysis

feature: Add codeql semantic analysis #9
@HappyZombies
release: up semver and update changelog
002e380
@HappyZombies HappyZombies added the release 🎉 Releases label Nov 4, 2021
@HappyZombies
Copy link
Member Author

For this release, I'd like to just publish this manually -- once #49 is reviewed and further worked on. It can be our strategy moving forward.

@jankapunkt
Copy link
Member

@HappyZombies yes I agree with manual publishing for this release, otherwise we would be stuck for a much longer time with outdated code.

Currently reviewing this one

jankapunkt
jankapunkt approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@jankapunkt jankapunkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I've seen this is all the code I have already reviewed in the recent PRs without deviation. From my end this can be published.

@jankapunkt
Copy link
Member

@jwerre can you please add your review so @HappyZombies can publish? I already approved.

@jwerre
Copy link
Contributor

jwerre commented Nov 10, 2021

@jankapunkt yes, I'll check this out today. Sorry for the delay.

jwerre
jwerre approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@jwerre jwerre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@HappyZombies HappyZombies merged commit 485147f into master Nov 10, 2021
@HappyZombies
Copy link
Member Author

Published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwerre jwerre jwerre approved these changes

@jankapunkt jankapunkt jankapunkt approved these changes

Assignees
No one assigned
Labels
release 🎉 Releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HappyZombies @jankapunkt @jwerre @oklas @jorenvandeweyer