Skip to content

Supporting Node12 and above #34

Closed
@HappyZombies

Description

@HappyZombies

Apparently, we (master) support Node 4 and above. We should, however, consider following the Node LTS and basically, support Node 12 and above.

The simplest change would be updating the package.json to update the engines to node >= 12.0.

The question is now What and where else would we need to make changes to show we support only Node12 and above? (obviously CI/CD testing, but that convo is for another issue).

Some things that we are merging to development only support Node 12 and above (example, mocha). So would this change be backwards breaking?

A fun little tidbit is that in the previous repository we forked, the travis.yml file actually was failing on Node 4 - Node 10...so maybe we already support Node 12 but just need to update the docs and package.json? https://travis-ci.org/github/oauthjs/node-oauth2-server

Metadata

Metadata

Assignees

No one assigned

    Labels

    completed 😀Work that has been completeddiscussion 🗨️Discussion about a particular topic.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions