DRAFT: Release workflows #49

jankapunkt · 2021-10-18T11:47:10Z

This PR implements a multi-stage testing and release workflow, as proposed on #36

The proposed workflow logic is therefore the following:

A. PR to development and master + pushing to them:

run basic unit tests (tests.yml)
do not run this basic tests on release-* branches, since they have their own extended workflow

B. PR / Push to a release-* branch:

run npm audit
run basic unit tests
run extended integration tests against all adapter packages
run publish dry-run for npm registry
run publish dry-run for github packages registry

C. Create a (new release)[https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository]

execute B
finally publish to NPM
finally publish to GH

The workflows A and B are triggered fully automated, while C still needs a release to be created by one of the maintainers. This is because a pull request to a release-* does not necessarily mean to create a new release from the package.

On the other hand - this could also be changed to, say, automatically create a new release at the end of workflow B when all checks have passed

jwerre · 2021-10-18T15:44:02Z

This looks great @jankapunkt. I do like the idea of automatically publishing at the end of workflow B.

HappyZombies · 2021-10-19T00:12:15Z

Fantastic, so to be clear, creating a release basically means making a tag IN github, correct?

HappyZombies · 2021-10-19T00:27:52Z

Also, when/what do we merge to 'master', the release-* branch or after we tag it/release it in GitHub we merge it master?

jankapunkt · 2021-10-19T07:50:21Z

@HappyZombies in it's current state it would mean to create a GitHub release (which also includes a Tag, yes)

Merging into master should be always the latest stable release, which is what many other projects do as well.

HappyZombies · 2021-10-19T13:52:36Z

Got it,

@jankapunkt this looks great, thanks a lot for doing it. Once this PR is merged I think we are good to move forward, setup the npm keys and what not, and do a release for 4.1.0. What do you think?

jankapunkt · 2021-10-19T13:56:49Z

Yes, exactly. However, I am not finished yet, since we need to manually test the new workflows. The good thing is, that the test-release workflow contains the exact same procedure as the release workfow, except that the publishing is a dry-run. I will create a release-test branch for testing this.

HappyZombies · 2021-10-21T11:09:15Z

@jankapunkt i am going to go ahead and follow this pattern but do it manually, and release what we currently have in development. I'd just like to release something right now with a lot of updates and what not so we can update our personal modules already. Unless there's something they needs to be tested/ran instantly?

jwerre · 2021-10-21T14:38:14Z

@jankapunkt, @HappyZombies I'm curious how the tags are being created for each version. I don't see it in the workflow, are we doing this locally when pushing to master? Something like:

Run test locally: npm test
Add and commit: git add . -A && git commit -m '...'
Update version: npm version patch
Deploy: git push origin master --tags

This is the way I tend to do it but I'm not super familiar with GitHub Actions. It would be nice if there was a way to automate these steps (I'd be happy to create a shell script to this effect).

Also, I feel like we touched on this somewhere but what are the plans for all the branches we create. I feel we could safely delete old branches since there is not point to having both tags and branches—keep things tidy.

HappyZombies · 2021-10-21T16:05:32Z

@jwerre When creating a tag we will have to use the "GitHub release" component that will create our tags for us. This will then run the GitHub action and publish to npm.

Basically, it'll be development-> release -> master. Then make a GitHub release, which will create a tag

As for the deletion of branches, I'm for it 100%

HappyZombies · 2021-10-25T23:15:26Z

I will be releasing 4.1.0 manually this week until we have this release strategy straightened out.

jankapunkt · 2021-10-30T07:55:59Z

@HappyZombies @jwerre I changed the base branch to release-tests the idea is the following:

we can't test the new actions just by opening a PR (because if that would be possible, someone could just open a PR, start any actions on the CI and maybe steal credentials or anything else).

In turn we need to pull this into the release-test branch and once pulled (after review) we can test the new included test-release-yml action, which also includes a npm publish and github publish dry run.

Once this is working we can pull it into development and have our release system ready for any new release :-)

jankapunkt · 2021-11-01T14:03:55Z

@jwerre @HappyZombies just a short ping - can you please read the above comments and let me know if you understand the intended steps? If you confirm, I'll merge into release-tests and immediately create a PR into development with additional release-check tests (but without an actual release, as this will be done manually using a GH release)

jwerre

Wonderful!

up semver and update changelog for dev branch

release 4.1.1 -> master

…om FStefanni/issue_89_20_649 Supported state in case of denial

Merge pull request #93 from node-oauth/fix-vcharfail-allowemptystate

Co-authored-by: Daniel Reguero <daniel.reguero@hotmail.com> Co-authored-by: Francesco Stefanni <francesco.stefanni@gizeroenergie.it>

Bumps [eslint](https://github.com/eslint/eslint) from 8.2.0 to 8.4.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.2.0...v8.4.1) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Daniel Reguero <daniel.reguero@hotmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

@jwerre

…ats #55 Merge pull request #108 from node-oauth/oauth-formats thanks to @jwerre

Bumps [sinon](https://github.com/sinonjs/sinon) from 11.1.2 to 12.0.1. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/master/docs/changelog.md) - [Commits](sinonjs/sinon@v11.1.2...v12.0.1) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [eslint](https://github.com/eslint/eslint) from 8.2.0 to 8.4.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.2.0...v8.4.1) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test example * created db & model factories * added refresh_token grant type test * removed failing test, not implemented feature * add reference to issue * client authentication test * random client credentials in test * replace math.random by crypto.randomBytes

@FStefanni

…ri via model #89 p.4 - support custom validateRedirectUri() - allow to implement model.validateRedirectUri - updated AuthorizeHandler - default conforms with RFC 6819 Section-5.2.3.5 - thanks to @FStefanni and @jorenvandeweyer

jankapunkt added 3 commits October 18, 2021 13:38

ci: ignore test.yml workflow on release-* branches PRs #36

d3b335f

ci: add tests-release.yml workflow to test release-integrity

8c080ff

ci: add release.yml to release a new version to registries

c6459b8

jankapunkt self-assigned this Oct 18, 2021

jankapunkt added security ❗ Address a security issue enhancement ✨ New feature or request labels Oct 18, 2021

jankapunkt linked an issue Oct 18, 2021 that may be closed by this pull request

Release strategy #36

Closed

jankapunkt added 3 commits October 26, 2021 06:42

ci(tests): make coverage generate lcov.info file

f4fc33b

ci(tests): make coverage generate lcov.info file as well as html #36

02e0a4d

ci(tests): fix spelling in coverage test script #36

ac7bb86

jankapunkt changed the base branch from development to release-test October 30, 2021 07:51

jankapunkt marked this pull request as ready for review October 30, 2021 07:53

jankapunkt requested review from HappyZombies and jwerre October 30, 2021 07:56

release: up semver and update changelog

002e380

HappyZombies mentioned this pull request Nov 4, 2021

release 4.1.0 -> master #51

Merged

jwerre approved these changes Nov 4, 2021

View reviewed changes

Merge pull request #52 from node-oauth/release-4.1.0

ad45e44

up semver and update changelog for dev branch

orgads and others added 24 commits November 24, 2021 22:15

Remove superfluous files from published package

d991b14

Merge pull request #7 from orgads/limit-files

5f2b0bb

release: up semver and update changelog

eaa9d03

release: add missing changelog

2fa8a7f

Merge pull request #87 from node-oauth/release-4.1.1

1b91ddc

release 4.1.1 -> master

fix(handlers): skip varcheck for state when allowEmptyState

4ca8032

Merge pull request #88 from node-oauth/release-4.1.1

52ee11d

supported custom validateRedirectUri

3df52fd

Supported state in case of denial

91f27f8

feature(): Supported state in case of denialMerge pull request #99 fr…

5824f79

…om FStefanni/issue_89_20_649 Supported state in case of denial

fix(handlers): skip varcheck for state when allowEmptyState #89 #93

aca48ce

Merge pull request #93 from node-oauth/fix-vcharfail-allowemptystate

added test for validateRedirectUri

88ef515

updated documentation

0a86e69

better implementation of validateRedirectUri

98a9d19

fixed misssing return statement in doc (#98)

ff9a5d2

Co-authored-by: Daniel Reguero <daniel.reguero@hotmail.com> Co-authored-by: Francesco Stefanni <francesco.stefanni@gizeroenergie.it>

added @node-oauth/formats module, removed is.js tests

4ff1f07

feature(core): extract is.js into standalone package @node-oauth/form…

10fe55d

…ats #55 Merge pull request #108 from node-oauth/oauth-formats thanks to @jwerre

added warning in docs, added extra tests that actually use parameters

3a1e433

Merge branch 'development' into issue_89_4_482

29e081b

jankapunkt linked an issue Jan 13, 2022 that may be closed by this pull request

Don't run CI on draft pull requests for releases #116

Closed

jankapunkt added 2 commits January 13, 2022 09:02

Merge branch 'development' into ci-release-package

7174693

feature(ci): release workflow only runs on non-draft pull requests

13aacce

jankapunkt requested review from jorenvandeweyer and Uzlopak January 13, 2022 08:15

jankapunkt merged commit 91559ed into release-test Jan 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

DRAFT: Release workflows #49

DRAFT: Release workflows #49

Uh oh!

jankapunkt commented Oct 18, 2021

Uh oh!

jwerre commented Oct 18, 2021

Uh oh!

HappyZombies commented Oct 19, 2021

Uh oh!

HappyZombies commented Oct 19, 2021 •

edited

Loading

Uh oh!

jankapunkt commented Oct 19, 2021

Uh oh!

HappyZombies commented Oct 19, 2021

Uh oh!

jankapunkt commented Oct 19, 2021

Uh oh!

HappyZombies commented Oct 21, 2021

Uh oh!

jwerre commented Oct 21, 2021

Uh oh!

HappyZombies commented Oct 21, 2021

Uh oh!

HappyZombies commented Oct 25, 2021

Uh oh!

jankapunkt commented Oct 30, 2021

Uh oh!

jankapunkt commented Nov 1, 2021

Uh oh!

jwerre left a comment

Uh oh!

Uh oh!

Uh oh!

DRAFT: Release workflows #49

DRAFT: Release workflows #49

Uh oh!

Conversation

jankapunkt commented Oct 18, 2021

Uh oh!

jwerre commented Oct 18, 2021

Uh oh!

HappyZombies commented Oct 19, 2021

Uh oh!

HappyZombies commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jankapunkt commented Oct 19, 2021

Uh oh!

HappyZombies commented Oct 19, 2021

Uh oh!

jankapunkt commented Oct 19, 2021

Uh oh!

HappyZombies commented Oct 21, 2021

Uh oh!

jwerre commented Oct 21, 2021

Uh oh!

HappyZombies commented Oct 21, 2021

Uh oh!

HappyZombies commented Oct 25, 2021

Uh oh!

jankapunkt commented Oct 30, 2021

Uh oh!

jankapunkt commented Nov 1, 2021

Uh oh!

jwerre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HappyZombies commented Oct 19, 2021 •

edited

Loading