Skip to content

release 4.1.0 -> master #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
Nov 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
17e2729
added test coverage using nyc
jankapunkt Oct 10, 2021
a88bb4d
Create tests.yml
jankapunkt Oct 10, 2021
917b4b9
uncomment line for coverage test until cov is added
jankapunkt Oct 10, 2021
dcd8a3d
ci change push branch dev to development
jankapunkt Oct 10, 2021
cf1ab06
Merge pull request #14 from node-oauth/add-ci
HappyZombies Oct 10, 2021
b7b8af6
Merge pull request #13 from node-oauth/test-coverage
HappyZombies Oct 10, 2021
4a9eb7b
docs: added contribution guide draft
jankapunkt Oct 10, 2021
534b5e7
Remove statuses, use http.STATUS_CODES
HappyZombies Oct 10, 2021
1722039
updated development guidelines
jankapunkt Oct 11, 2021
6a0c93c
contribution guidelines added guiding principles
jankapunkt Oct 11, 2021
c833a37
pull request template added
jankapunkt Oct 11, 2021
de41dc7
docs removed maintainers section from contribution guide
jankapunkt Oct 11, 2021
4d893e4
Merge pull request #26 from node-oauth/feature.http-status
HappyZombies Oct 11, 2021
e650264
removed jshint added eslint
jwerre Oct 11, 2021
9ebf817
merge with development branch
jwerre Oct 11, 2021
18d2404
removed should added chai
jwerre Oct 11, 2021
05b8944
removed some log statements
jwerre Oct 11, 2021
0cf3b11
removed 'no-prototype-builtins' from eslint
jwerre Oct 11, 2021
ca47721
docs: add commit message convention and coding rules
oklas Oct 12, 2021
b4e344d
tests validator is tested for all unicode ranges
jankapunkt Oct 12, 2021
f57f4c3
validator is add missing variable in is.uchar
jankapunkt Oct 12, 2021
615bd75
tests validator also test for multiple characters
jankapunkt Oct 12, 2021
c0e4ef1
eslint enable no-control-regex and disable only in validator
jankapunkt Oct 12, 2021
9775b39
tests validator is increase timeout
jankapunkt Oct 12, 2021
60bad87
docs: lightly softify commit convention requirements
oklas Oct 12, 2021
5a98700
refactor: update mocha to latest version #17
HappyZombies Oct 12, 2021
4003209
removed tab in token-model_test.js
jwerre Oct 12, 2021
a6c257f
Merge pull request #29 from node-oauth/chai
HappyZombies Oct 12, 2021
391fbef
added chai to is_test.js
jwerre Oct 12, 2021
2e4d14f
removed jshint
jwerre Oct 12, 2021
7a3a9b0
ci (dev-infra): removed travis-ci file #34
jankapunkt Oct 13, 2021
50caf40
ci (dev-infra): add matrix strategy to test multiple node versions
jankapunkt Oct 13, 2021
0bb1b23
Merge pull request #32 from oklas/contrib
HappyZombies Oct 13, 2021
df4dc62
Pulled from development
HappyZombies Oct 13, 2021
66d46be
Ran npm install, add mocharc.yml file
HappyZombies Oct 13, 2021
fe789aa
changed config file
HappyZombies Oct 13, 2021
81aac3a
Merge pull request #35 from node-oauth/feature-ci-multiple-targets
HappyZombies Oct 13, 2021
12f0a80
disallow the use of console
jwerre Oct 13, 2021
c0196f3
Merge pull request #30 from node-oauth/lint
HappyZombies Oct 13, 2021
79bcb7c
resolved package conflicts
jwerre Oct 13, 2021
8bb0dcc
Merge pull request #33 from node-oauth/feature.update-mocha
HappyZombies Oct 13, 2021
4985ca7
docs: correct types and available scripts and add info about removing…
jankapunkt Oct 13, 2021
fcec276
docs: add pull request template
jankapunkt Oct 13, 2021
3dc2f6d
Merge pull request #18 from node-oauth/contribution-guidelines
HappyZombies Oct 13, 2021
0d3f621
test: Update sinon to latest version #17
HappyZombies Oct 13, 2021
b1676fb
Merge pull request #39 from node-oauth/feature.sinon-update
HappyZombies Oct 13, 2021
f8c398f
build(packaging): update minimal supported node version to 12 #34
jankapunkt Oct 14, 2021
769878d
fix(security): use sha256 for token generation #38
jankapunkt Oct 14, 2021
26b3eb3
Merge pull request #41 from node-oauth/update-node-version
HappyZombies Oct 14, 2021
ff6a450
Merge pull request #43 from node-oauth/fix-sha1-to-sha256
HappyZombies Oct 14, 2021
8e05cb5
Remove lodash dependency (#37)
jorenvandeweyer Oct 14, 2021
156b34f
ci(dev-infra): add codeql semantic analysis #16 #36
jankapunkt Oct 15, 2021
be8121b
ci(dev-infra): make codeql scane on push and pr equal #16 #36
jankapunkt Oct 15, 2021
100e8ae
refactor:Fix typos and clean up package.json and package-lock.json
HappyZombies Oct 15, 2021
ffb28c3
Merge pull request #46 from node-oauth/feature.small-cleanup
HappyZombies Oct 15, 2021
cfa907d
Merge pull request #45 from node-oauth/feature-ci-static-semantic-ana…
HappyZombies Oct 19, 2021
002e380
release: up semver and update changelog
HappyZombies Nov 4, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"extends": "eslint:recommended",
"env": {
"node": true,
"mocha": true,
"es6": true
},
"parserOptions": {
"ecmaVersion": 9,
"sourceType": "module",
"ecmaFeatures" : {
"globalReturn": false,
"impliedStrict": true,
"jsx": false
}
},
"rules": {
"indent": [
"error",
2
],
"linebreak-style": [
"error",
"unix"
],
"quotes": [
"error",
"single"
],
"semi": [
"error",
"always"
],
"no-console": [
"error"
],
"no-unused-vars": [
"error",
{
"vars": "all",
"args": "none",
"ignoreRestSiblings": false
}
]
}
}

2 changes: 0 additions & 2 deletions .github/FUNDING.yml

This file was deleted.

65 changes: 65 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
<!-- ---------------------------------------------------------------------------

🎉 THANK YOU FOR YOUR CONTRIBUTION! 🎉

We highly appreciate your time and effort to this project!


⚠ PLEASE READ THIS FIRST ⚠

1. If this is a fix for a security vulnerability you discovered please don't
just open this PR until we have privately discussed the vulnerability. Disclosing
it without contacting us can lead to severe implications for many applications
that run on this project.

2. Make sure you have read the contribution guidelines for this project in
order to raise the chance of getting your PR accepted. This saves you valuable
time and effort.

3. The following structure is a basic guideline. If a section does not apply you
can remove it.
---------------------------------------------------------------------------- -->

## Summary
<!-- ---------------------------------------------------------------------------
⚠ Provide one or two paragraphs
---------------------------------------------------------------------------- -->



## Linked issue(s)
<!-- ---------------------------------------------------------------------------
⚠ If there is no issue for this PR we won't review it
---------------------------------------------------------------------------- -->



## Involved parts of the project
<!-- ---------------------------------------------------------------------------
⚠ Which parts of the code is affected and which OAuth2 workflows are involved
---------------------------------------------------------------------------- -->



## Added tests?
<!-- ---------------------------------------------------------------------------
⚠ Did you add tests that cover your changes?
---------------------------------------------------------------------------- -->



## OAuth2 standard
<!-- ---------------------------------------------------------------------------
⚠ This section is important in order to review compliance with the standard(s).
Please refer to the standard if your PR affects any functionality or is
otherwise related to the standard(s) in any way
---------------------------------------------------------------------------- -->



## Reproduction
<!-- ---------------------------------------------------------------------------
⚠ How can we reproduce your changes in an app? This is especially important
when new features are added
---------------------------------------------------------------------------- -->

33 changes: 15 additions & 18 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,17 @@
version: 2
updates:
- package-ecosystem: npm
directory: "/"
schedule:
interval: daily
open-pull-requests-limit: 10
ignore:
- dependency-name: sinon
versions:
- 10.0.0
- 9.2.4
- dependency-name: mocha
versions:
- 8.2.1
- 8.3.0
- 8.3.1
- dependency-name: lodash
versions:
- 4.17.20
- package-ecosystem: npm
directory: "/"
schedule:
interval: daily
open-pull-requests-limit: 10
ignore:
- dependency-name: sinon
versions:
- 10.0.0
- 9.2.4
- dependency-name: mocha
versions:
- 8.2.1
- 8.3.0
- 8.3.1
68 changes: 68 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
# For most projects, this workflow file will not need changing; you simply need
# to commit it to your repository.
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
#
# ******** NOTE ********
# We have attempted to detect the languages in your repository. Please check
# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL Semantic Analysis"

on:
push: # all pushes
pull_request: # all PR
schedule:
- cron: '0 2 * * *' # every night at 2am

jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest
permissions:
actions: read
contents: read
security-events: write

strategy:
fail-fast: true
matrix:
language: [ 'javascript' ]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
# Learn more:
# https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed

steps:
- name: Checkout repository
uses: actions/checkout@v2

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.
# queries: ./path/to/local/query, your-org/your-repo/queries@main

# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
# - name: Autobuild
# uses: github/codeql-action/autobuild@v1

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl

# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language

#- run: |
# make bootstrap
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
75 changes: 75 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
name: Test suite

on:
push:
branches:
- master # allthough master is push protected we still keep it
- development
pull_request: # runs on all PR

jobs:
# ----------------------------------
# uncomment when a linter is added
# ----------------------------------

# lintjs:
# name: Javascript lint
# runs-on: ubuntu-latest
# steps:
# - name: checkout
# uses: actions/checkout@v2
#
# - name: setup node
# uses: actions/setup-node@v1
# with:
# node-version: '12.x'
#
# - name: cache dependencies
# uses: actions/cache@v1
# with:
# path: ~/.npm
# key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
# restore-keys: |
# ${{ runner.os }}-node-
# - run: npm ci
# - run: npm run lint

unittest:
name: unit tests
runs-on: ubuntu-latest
# uncomment when a linter is added
# needs: [lintjs]
strategy:
matrix:
node: [12, 14, 16]
steps:
- name: Checkout ${{ matrix.node }}
uses: actions/checkout@v2

- name: Setup node ${{ matrix.node }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}

- name: Cache dependencies ${{ matrix.node }}
uses: actions/cache@v1
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ matrix.node }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-${{ matrix.node }}
- run: npm ci
- run: npm run test:coverage

# ----------------------------------
# uncomment when a linter is added
# ----------------------------------

# - name: check coverage
# uses: devmasx/coverage-check-action@v1.2.0
# with:
# type: lcov
# result_path: coverage/lcov.info
# min_coverage: 90
# token: ${{github.token}}

5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ npm-debug.log*~
auto-save-list
tramp
.\#*
.vscode

# Org-mode
.org-id-locations
*_archive

# coverage
coverage
.nyc_output
1 change: 0 additions & 1 deletion .jshintignore

This file was deleted.

26 changes: 0 additions & 26 deletions .jshintrc

This file was deleted.

8 changes: 8 additions & 0 deletions .mocharc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
recursive: true
reporter: "spec"
retries: 1
slow: 20
timeout: 2000
ui: "bdd"
require: test/assertions
# for more options see here https://github.com/mochajs/mocha/blob/master/example/config/.mocharc.yml
11 changes: 0 additions & 11 deletions .travis.yml

This file was deleted.

13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
## Changelog

## 4.1.0
### Changed
* Bump dev dependencies to resolve vulnerabilities
* Replaced jshint with eslint along with should and chai
* Use sha256 when generating tokens

### Added
* Added markdown files to discuss coding rules, commit conventions, contributing guidelines, etc.

### Removed
* Removed lodash dependency
* Removed statuses package and use built in http.STATUS_CODES instead.

### 4.0.0
* Bump jshint from 2.12.0 to 2.13.0
* Bump jshint from 2.12.0 to 2.13.0
Expand Down
Loading