Bump mocha from 5.2.0 to 9.1.2 #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappyZombies
added
the
dependencies 🔌
|
recursive: true
reporter: 'spec'
retries: 1
slow: 20
timeout: '2s'
ui: 'bdd'
# some additional files that could be loaded. e.g.: env.js
# file:
# - '/path/to/some/file' |
|
@jankapunkt please re-review, I added the new mocha config file. |
|
@HappyZombies @jankapunkt Are you guys cool with me merging these once they're approved? |
|
@jwerre I added you as a reviewer, if it looks good to you go ahead and approve and I'll merge it in after the approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 📖
This PR simply updates mocha from 5.2.0 to 9.1.2
After looking over the CHANGELOG for mocha, it appears that a lot of the breaking changes will NOT affect this repo (since they were never really used). All tests pass successfully and look good on my end, and I have not seen any deprecation warnings.
NOTE: Mocha version 9 only works with Node 12 and above (Node 12 is currently it LTS). With this in mind, we should begin the transition of only supporting Node 12 and above.
Linked issue(s) 🔗
#17
Will also close #11
Involved parts of the project ⚙️
None are affected, only tests are, all of which are currently passing.