This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Gathered fixes from abandoned PRs. #6762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobooth
added
2.3.x
hguthrie
suggested changes
Mar 2, 2020
src/guides/v2.3/install-gde/install/cli/install-cli-subcommands-enable.md
Outdated
Show resolved
Hide resolved
| @@ -135,7 +135,7 @@ require([ | |||
|
|
|||
| ## Calling JS components requiring initialization in JS files {#js_widget_init} | |||
|
|
|||
| To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget is intiialized on the `[data-role=example]` element as illustration): | |||
| To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget is initialized on the `[data-role=example]` element as illustration): | |||
There was a problem hiding this comment.
This doesn't even read correctly. Needs work.
Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>
…s-enable.md Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>
keharper
reviewed
Mar 2, 2020
src/guides/v2.3/install-gde/install/cli/install-cli-subcommands-enable.md
Outdated
Show resolved
Hide resolved
| @@ -135,7 +135,7 @@ require([ | |||
|
|
|||
| ## Calling JS components requiring initialization in JS files {#js_widget_init} | |||
|
|
|||
| To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget is intiialized on the `[data-role=example]` element as illustration): | |||
| To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget is initialized on the `[data-role=example]` element as illustration): | |||
There was a problem hiding this comment.
Suggested change
| To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget is initialized on the `[data-role=example]` element as illustration): | |
| To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget that is initialized on the `[data-role=example]` element below: |
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
hguthrie
approved these changes
Mar 2, 2020
|
running tests |
|
Hi @dobooth, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) fixes 3 topics that had stale PRs.
#6690
#6692
#6707
Affected DevDocs pages