Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Gathered fixes from abandoned PRs. #6762

Merged
merged 4 commits into from
Mar 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/guides/v2.3/frontend-dev-guide/css-topics/using-fonts.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ To ensure the stability of your customizations and prevent upgrades from overwri
}
```

1. You must edit the `app/code/Magento/Theme/view/frontend/layout/default_head_blocks.xml` file to declare your fonts; otherwise, Magento 2.3 is not able to create the `static/web/fonts/` directory. See `app/code/Magento/Theme/view/frontend/layout/default_head_blocks.xml`.

`@font-display: swap` is declared by default for Magento Blank theme in `app/design/frontend/Magento/blank/web/css/source/_typography.less`.

Fallback web fonts that are used by default in Magento are located in `lib/web/css/source/lib/variables/_typography.less`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ where
* `-f` or `--force` to force a module to be enabled or disabled despite dependencies. Before you use this option, see [About enabling and disabling modules](#instgde-cli-subcommands-enable-modules).
* `-c` or `--clear-static-content` cleans [generated static view files]({{ page.baseurl }}/config-guide/cli/config-cli-subcommands-static-view.html#config-cli-static-overview).

Failure to clear static view files might result in issues if there are multiple files with the same name and you don't clear all of them.
Failure to clear static view files might result in issues if there are multiple files with the same name and you do not clear all of them.

In other words, because of [static file fallback]({{ page.baseurl }}/config-guide/cli/config-cli-subcommands-static-view.html) rules, if you do not clear static files and there is more than one file named `logo.gif` that are different, fallback might cause the wrong file to display.
In other words, because of the [static file fallback]({{ page.baseurl }}/config-guide/cli/config-cli-subcommands-static-view.html) rules, if you do not clear static files and there is more than one file named `logo.svg` that are different, fallback might cause the wrong file to display.

Use the following command to list enabled and disabled modules:

Expand Down
2 changes: 1 addition & 1 deletion src/guides/v2.3/javascript-dev-guide/javascript/js_init.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ require([

## Calling JS components requiring initialization in JS files {#js_widget_init}

To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget is intiialized on the `[data-role=example]` element as illustration):
To call a widget with JS code, use a notation similar to the ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget. It is initialized on the `[data-role=example]` element as below):

```javascript
$('[data-role=example]').accordion();
Expand Down