Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add missing documentation step #6690

Closed

Conversation

operator888
Copy link
Member

Purpose of this pull request

I was following the documentation
https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/css-topics/using-fonts.html
in order to add my custom fonts to the project, but after finishing all steps the steps my fonts were not exported in the static/fonts directory. So this documentation page is incomplete because important information is missing.

After searching I've found the following step in another page of the DevDocs https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/layouts/xml-manage.html#layout_markup_css
So, after I followed the steps to include my custom fonts, everything worked.

But there must be a link to that page because it is important for all who might want to include custom fonts in their Magento installations, and load the fonts from their local directories and not via an external call to the cloud.

Affected DevDocs pages

Links to Magento source code

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@operator888
Copy link
Member Author

operator888 commented Feb 20, 2020

The bot says that no Adobe CLA is found. How is this possible?
I signed that a few weeks ago, and im officially part of the Magento repo community here in github.
Do I have to sign an CLA everytime i do a contribution?

@dobooth
Copy link
Contributor

dobooth commented Feb 20, 2020

Hi @operator888 Thanks for the contribution! Not sure why the CLA is asking again. Could be for a different Adobe organization? Not sure, but if you sign below, you should only have to do so once. And while you are here? You edited the v2.1 file. Not only do we no longer publish v2.1, but a few weeks ago, we stopped taking PRs for v2.2! So, if this change is still important for v2.3, please move your change over to that version and we can take the change. Thanks for the help.

@operator888
Copy link
Member Author

operator888 commented Feb 20, 2020

Hi @dobooth and thank you for reviewing.
Well, I edited that file because the v2.3 and the v2.2 for this topic, are both symlinked to the v2.1 documentation. If you open locally the folder/file I edited you will see all files are symliks to v2.1 files...
Here please see that im editing the v2.3 file. https://ibb.co/vXvc7kF

So, whats the best way to do this now?
And yes, I believe it is important topic because without my added step, all newcomers trying to install custom fonts will fail if they simply follow the current documentation because it is missing a very important step.

@dobooth
Copy link
Contributor

dobooth commented Feb 20, 2020

That also applies to #6692

Copy link
Contributor

@dobooth dobooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my note above.

Copy link
Member Author

@operator888 operator888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok by me.
im sorry for my late respond on this task.
As for editing the v.2.3.3 file, I dont think thats possible, because i dont find that file, because it doesnt exist. Its only a shortcut to v2.2 which is again a shortcut to v2.1.

thank you @dobooth
let me know if it is something else i could do here.

@dobooth
Copy link
Contributor

dobooth commented Feb 27, 2020

I think your branch really needs to be updated. All those shortcuts were removed months ago. Do a bit git pull or you can just go to https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/css-topics/using-fonts.html and in the upper right corner, click the "Edit this page on Github" link and just move your change to there.

@dobooth
Copy link
Contributor

dobooth commented Feb 27, 2020

and we have also moved the /guides/ files to /src/guides/

@dobooth
Copy link
Contributor

dobooth commented Mar 2, 2020

Closing as abandoned. Moved fix to another PR.

@dobooth dobooth closed this Mar 2, 2020
@ghost
Copy link

ghost commented Mar 2, 2020

Hi @operator888, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants