-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
An admin must run tests on this PR before it can be merged. |
The bot says that no Adobe CLA is found. How is this possible? |
Hi @operator888 Thanks for the contribution! Not sure why the CLA is asking again. Could be for a different Adobe organization? Not sure, but if you sign below, you should only have to do so once. And while you are here? You edited the v2.1 file. Not only do we no longer publish v2.1, but a few weeks ago, we stopped taking PRs for v2.2! So, if this change is still important for v2.3, please move your change over to that version and we can take the change. Thanks for the help. |
Hi @dobooth and thank you for reviewing. So, whats the best way to do this now? |
That also applies to #6692 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my note above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok by me.
im sorry for my late respond on this task.
As for editing the v.2.3.3 file, I dont think thats possible, because i dont find that file, because it doesnt exist. Its only a shortcut to v2.2 which is again a shortcut to v2.1.
thank you @dobooth
let me know if it is something else i could do here.
I think your branch really needs to be updated. All those shortcuts were removed months ago. Do a bit |
and we have also moved the /guides/ files to /src/guides/ |
Closing as abandoned. Moved fix to another PR. |
Hi @operator888, thank you for your contribution! |
Purpose of this pull request
I was following the documentation
https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/css-topics/using-fonts.html
in order to add my custom fonts to the project, but after finishing all steps the steps my fonts were not exported in the static/fonts directory. So this documentation page is incomplete because important information is missing.
After searching I've found the following step in another page of the DevDocs https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/layouts/xml-manage.html#layout_markup_css
So, after I followed the steps to include my custom fonts, everything worked.
But there must be a link to that page because it is important for all who might want to include custom fonts in their Magento installations, and load the fonts from their local directories and not via an external call to the cloud.
Affected DevDocs pages
Links to Magento source code