Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Minor/typo fix #6692

Closed
wants to merge 3 commits into from
Closed

Conversation

operator888
Copy link
Member

Purpose of this pull request

Corrects the file ending of the logo.gif to the right one which is logo.svg
As far as I know and see inside the Default Magento2 installations, the logo is SVG.
Why to put a GIF logo...?
I think this must had been overlooked in all the previous documentations for v2.1 and v2.2 too because its also referenced wrong there too.

Affected DevDocs pages

https://docs.magento.com/m2/ce/user_guide/design/logo-upload.html

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

Copy link
Contributor

@dobooth dobooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your branch and put this fix into the v2.3 branch, if needed. We no longer support v2.1 and v2.2.

@dobooth
Copy link
Contributor

dobooth commented Feb 27, 2020

Like my comment in your other PR, you can use the "Edit this page on Github" link to make a new PR for this fix. Then we can close this one.

@dobooth
Copy link
Contributor

dobooth commented Mar 2, 2020

Closing as abandoned. Moved fix to another PR.

@dobooth dobooth closed this Mar 2, 2020
@ghost
Copy link

ghost commented Mar 2, 2020

Hi @operator888, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants