This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Update js_init.md #6707
Closed
Update js_init.md #6707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Krish TechnoLabs
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
rogyar
added
Editorial
rogyar
suggested changes
Feb 24, 2020
| @@ -135,7 +135,7 @@ require([ | |||
|
|
|||
| ## Calling JS components requiring initialization in JS files {#js_widget_init} | |||
|
|
|||
| To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget is intiialized on the `[data-role=example]` element as illustration): | |||
| To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget is intialized on the `[data-role=example]` element as illustration): | |||
There was a problem hiding this comment.
Hi @saphaljha. I'm still not sure that the spelling is correct
Suggested change
| To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget is intialized on the `[data-role=example]` element as illustration): | |
| To call a widget in JS code, use a notation similar to the following ([accordion]({{ page.baseurl }}/javascript-dev-guide/widgets/widget_accordion.html) widget is initialized on the `[data-role=example]` element as illustration): |
|
Hi @saphaljha Thanks for the contribution. If you can please sign the Adobe CLA below, we can get this PR processed. |
|
Closing as abandoned. Moved fix to another PR. |
|
Hi @saphaljha, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) ...
Affected DevDocs pages
Links to Magento source code