Generating space-before-function-paren (#147)
#273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
requested changes
Dec 12, 2019
JoshuaKGoldberg
added
the
status: waiting for author
dimabory
force-pushed
the
bugfix/#147
branch
from
5b3e131 to
ead9ab5
Compare
JoshuaKGoldberg
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
This is looking good! I left a couple of comments @dimabory if you have time to address them. If you don't soon, that's fine too! We can merge this in and file those as follow-up issues. 🚀
dimabory
force-pushed
the
bugfix/#147
branch
from
ead9ab5 to
3597079
Compare
JoshuaKGoldberg
added
status: waiting for reviewer
JoshuaKGoldberg
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview