Skip to content

Commit 5b3e131

Browse files
committed
fix: generating space-before-function-paren (#147)
1 parent 2cccfd0 commit 5b3e131

File tree

3 files changed

+21
-1
lines changed

3 files changed

+21
-1
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
.idea
12
*.tsbuildinfo
23
*.d.ts
34
*.log

src/rules/converters/space-before-function-paren.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
import { RuleConverter } from "../converter";
22

3+
function isExistedESLintOption(rule: string) {
4+
return ["anonymous", "named", "asyncArrow"].includes(rule);
5+
}
6+
37
export const convertSpaceBeforeFunctionParen: RuleConverter = tslintRule => {
48
return {
59
rules: [
610
{
711
...(tslintRule.ruleArguments.length !== 0 && {
8-
ruleArguments: tslintRule.ruleArguments,
12+
ruleArguments: tslintRule.ruleArguments.filter(isExistedESLintOption),
913
}),
1014
ruleName: "space-before-function-paren",
1115
},

src/rules/converters/tests/space-before-function-paren.test.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,19 @@ describe(convertSpaceBeforeFunctionParen, () => {
2929
],
3030
});
3131
});
32+
33+
test("conversion with all existing arguments", () => {
34+
const result = convertSpaceBeforeFunctionParen({
35+
ruleArguments: ["anonymous", "named", "asyncArrow", "method", "constructor"],
36+
});
37+
38+
expect(result).toEqual({
39+
rules: [
40+
{
41+
ruleArguments: ["anonymous", "named", "asyncArrow"],
42+
ruleName: "space-before-function-paren",
43+
},
44+
],
45+
});
46+
});
3247
});

0 commit comments

Comments
 (0)