Incorrectly generated space-before-function-paren

[akx]

🐛 Bug Report

• tslint-to-eslint-config version: 0.2.5
• ESLint version: 6.2.2
• Node version: 12.6

Actual Behavior

The tool generates a

       "space-before-function-paren": [
           "error",
           {
               "anonymous": "never",
               "asyncArrow": "always",
               "constructor": "never",
               "method": "never",
               "named": "never",
           },
       ],

rule which does not validate when Eslint is starting:

	Configuration for rule "space-before-function-paren" is invalid:
	Value {"anonymous":"never","asyncArrow":"always","constructor":"never","method":"never","named":"never"} should be equal to one of the allowed values.
	Value {"anonymous":"never","asyncArrow":"always","constructor":"never","method":"never","named":"never"} should NOT have additional properties.
	Value {"anonymous":"never","asyncArrow":"always","constructor":"never","method":"never","named":"never"} should match exactly one schema in oneOf.

Expected Behavior

The rule is correctly generated according to the spec. It seems method and constructor shouldn't be there.

[Shubhamchinda]

Hey, Can I work on this issue?

[JoshuaKGoldberg]

😍 yes please, @Shubhamchinda! That'd be fantastic!

docs/Development.md has a root overview for how to get started. Within that, docs/Architecture.md#rule-converters talks about how these converters operate.

[Shubhamchinda]

Hey @JoshuaKGoldberg , Do we need to make the changes in file ? Let me know if I'm going correct.

Another thing I also want to know is, how can I test the changes ?

Thanks a lot! :)

[JoshuaKGoldberg]

Do we need to make the changes in file?

Not quite. That ESLint repository is the source of ESLint rules. This tslint-to-eslint-config repository is a separate description of how to convert TSLint rules' configurations to work with those rules. So there are three repositories:

• ESLint
• TSLint
• eslint-to-tslint-config

We're exclusively working within eslint-to-tslint-config. You'll want to look at:

tslint-to-eslint-config/src/rules/converters/space-before-function-paren.ts

Line 3 in b062d10

export const convertSpaceBeforeFunctionParen: RuleConverter = tslintRule => {

how can I test the changes ?

Unit tests for the space-before-function-parent converter exist here:

tslint-to-eslint-config/src/rules/converters/tests/space-before-function-paren.test.ts

Line 3 in b062d10

describe(convertSpaceBeforeFunctionParen, () => {

This is a standard Jest test setup, so running jest space-before-function-parent on the console will re-run tests. Add --watch to have them continuously re-run as you update files.

[Shubhamchinda]

Alright! I am doing this!
Thanks

[KingDarBoja]

Any updates on this? I got the same error while testing generated lint rules.

[JoshuaKGoldberg]

Ping @Shubhamchinda - still interested in this?

[ElkeCodes]

If @Shubhamchinda is not interested anymore, I'd happily take it over :)

[JoshuaKGoldberg]

Ping @ElkeBxl - still interested in this?