fix: generating space-before-function-paren (#147)

Author: dimabory

src/rules/converters/space-before-function-paren.ts

@@ -1,11 +1,22 @@
 import { RuleConverter } from "../converter";
 
+function isExistedESLintOption(rule: string) {
+    return ["anonymous", "named", "asyncArrow"].includes(rule);
+}
+
 export const convertSpaceBeforeFunctionParen: RuleConverter = tslintRule => {
+    const tslintRuleArguments = tslintRule.ruleArguments;
+    const ruleArguments = tslintRuleArguments.filter(isExistedESLintOption);
     return {
         rules: [
             {
-                ...(tslintRule.ruleArguments.length !== 0 && {
-                    ruleArguments: tslintRule.ruleArguments,
+                ...(tslintRuleArguments.length !== 0 && {
+                    ruleArguments,
+                    ...(tslintRuleArguments.length > ruleArguments.length && {
+                        notices: [
+                            'ESLint doesn\'t support the following options: "method" and "constructor". These two options can be covered by "named" therefore make sure you have set this option.',
+                        ],
+                    }),
                 }),
                 ruleName: "space-before-function-paren",
             },

src/rules/converters/tests/space-before-function-paren.test.ts

@@ -29,4 +29,40 @@ describe(convertSpaceBeforeFunctionParen, () => {
             ],
         });
     });
+
+    test("conversion with all existing arguments", () => {
+        const result = convertSpaceBeforeFunctionParen({
+            ruleArguments: ["anonymous", "named", "asyncArrow", "method", "constructor"],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    notices: [
+                        'ESLint doesn\'t support the following options: "method" and "constructor". These two options can be covered by "named" therefore make sure you have set this option.',
+                    ],
+                    ruleArguments: ["anonymous", "named", "asyncArrow"],
+                    ruleName: "space-before-function-paren",
+                },
+            ],
+        });
+    });
+
+    test('conversion with not supported options ["method", "constructor"]', () => {
+        const result = convertSpaceBeforeFunctionParen({
+            ruleArguments: ["method", "constructor"],
+        });
+
+        expect(result).toEqual({
+            rules: [
+                {
+                    notices: [
+                        'ESLint doesn\'t support the following options: "method" and "constructor". These two options can be covered by "named" therefore make sure you have set this option.',
+                    ],
+                    ruleArguments: [],
+                    ruleName: "space-before-function-paren",
+                },
+            ],
+        });
+    });
 });