Fix controller index action #9703
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ombaya, javiereguiluz) This PR was merged into the 4.0 branch. Discussion ---------- Update flex.rst - Add step in migration-process I added the step to add 'symfony/symfony' to the `conflict`-section of your composer.json-file. I did not do this until after the step to change your `index.php`-section. This resulted in a lot of recipe's not being executed since the libraries for that were still being installed by `symfony/symfony`. Language improvements are welcomed since English is not my mother tongue. Commits ------- 336260c Minor change 67af1e0 Update flex.rst - Add step in migration-process
This PR was merged into the master branch. Discussion ---------- Update Documentation excluded_ajax_paths sf4 Linked with this PR : symfony/symfony#26177 Commits ------- 31f75d3 update doc sf4 for excluded_ajax_paths
This PR was merged into the 4.0 branch. Discussion ---------- use diff code block Commits ------- ccfdead use diff code block
Rename app/console references to bin/console
This PR was merged into the 4.0 branch. Discussion ---------- Update framework.rst Rename app/console references to bin/console Commits ------- 91608f0 Update framework.rst
* 3.4: (23 commits) Update access_control.rst Update forms.rst Documented how to create lazy-loaded Twig extensions Add missing colon after protocol in link [Contributing] Reviewing an issue/pull-request (Giving constructive criticism) minor symfony#9328 Markup in Config Validation example (ProgMiner) Update service_container.rst Rename missing allowCustomResponseCode to correct allowCustomResponseCode Fix static method call Explaining the "one-to-many" case more explicitly fix console script path fixing second stopwatch example in phpunit-bridge docs fix console script path improve validation groups references ...
* 4.0: (31 commits) Update framework.rst Update access_control.rst Update forms.rst Documented how to create lazy-loaded Twig extensions use diff code block Add missing colon after protocol in link Update flex.rst - Add step in migration-process Removed an extra blank line [Contributing] Reviewing an issue/pull-request (Giving constructive criticism) Update dbal.rst minor symfony#9328 Markup in Config Validation example (ProgMiner) Update service_container.rst Rename missing allowCustomResponseCode to correct allowCustomResponseCode Update requirements.rst Fix static method call Explaining the "one-to-many" case more explicitly ...
* 3.4: Clarify unanimous access strategy description Improved variable naming
* 4.0: Clarify unanimous access strategy description Improved variable naming
This PR was merged into the master branch. Discussion ---------- Update configuration for argon2i encoder From: symfony/symfony#26175 Commits ------- a3e9bf2 Update configuration for argon2i encoder
* 3.4: Use the shorthand notation when applicable
* 4.0: Use the shorthand notation when applicable
* 3.4: fixed RST syntax
* 4.0: fixed RST syntax
* 3.4: Update dependency_injection.rst Update dependency_injection.rst Fix some misspellings Explained how the URL trailing slash redirection works
* 4.0: Update dependency_injection.rst Update dependency_injection.rst Fix some misspellings Explained how the URL trailing slash redirection works
This PR was merged into the 4.0 branch. Discussion ---------- Typo fix Simple Typo fix Commits ------- f7b6f3a Typo fix
This PR was squashed before being merged into the master branch (closes symfony#9385). Discussion ---------- Documented the smart URL redirection This fixes symfony#9330. Commits ------- 49cfb48 Documented the smart URL redirection
…eguiluz) This PR was merged into the master branch. Discussion ---------- Twig Extension runtimes are autoconfigured Commits ------- b0e984c Twig Extension runtimes are autoconfigured
…with 307/308 HTTP status codes (ZipoKing, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle] PR #26213 Document redirections with 307/308 HTTP status codes This documents changes introduced with pull request symfony/symfony#26213 Commits ------- 9468bf9 Reword and added an example c8ce65d Changes after @Simperfit review b3984d0 [PR #26213 Document redirections with 307/308 HTTP status codes
* 3.4: Update json_login_setup.rst Document switch_user.stateless firewall option Fixed small typo mistake
* 4.0: Update json_login_setup.rst Fixed small typo mistake
Until now the JMSSecurityExtraBundle not support Symfony 4.*, => So we can't install it.
…oo in RedirectController (Simperfit, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle] feature: redirect query params too in RedirectController Adding documentation for the redirectAction improvement. This needs the feature to be merged first Commits ------- ba5c343 Restored a removed character 6c92c05 Reworded the new option explanation 7210586 feature: redirect query params too in RedirectController
…e phpunit.xml.dist (lyrixx, javiereguiluz) This PR was merged into the master branch. Discussion ---------- Document the usage of SYMFONY_PHPUNIT_REMOVE in the phpunit.xml.dist refs symfony#9637 Commits ------- 8c9c9ee Minor reword for consistency f91ac32 document the usage of SYMFONY_PHPUNIT_REMOVE in the phpunit.xml.dist
* 3.4: Update serializer.rst Tweak wording in Upgrading a Patch Version Reword the explanation about HTTP exceptions added documentation for author tag management be more clear about child form to be themed FIX : accessing global variable tokenStorage Wrong attribute serializer xml fix FormError access in Twig template class attribute still needed in some cases Be consistent how we write "core team" add missing redirection map entry Added a note about using the security checker independently Use the default article title Use "children" property instead of "child" Update web_server_configuration.rst Encore.configureUrlLoader() documentation Updated a Twig example
* 4.0: (21 commits) 9677 price is an integer Update serializer.rst Tweak wording in Upgrading a Patch Version Reword the explanation about HTTP exceptions Fix controller references in ESI docs added documentation for author tag management be more clear about child form to be themed FIX : accessing global variable tokenStorage Wrong attribute serializer xml fix FormError access in Twig template Update the dynamic form article to use modern Symfony practices class attribute still needed in some cases Be consistent how we write "core team" add missing redirection map entry Added a note about using the security checker independently Use the default article title Use "children" property instead of "child" Update web_server_configuration.rst Encore.configureUrlLoader() documentation ...
This PR was merged into the 3.4 branch. Discussion ---------- Update locale_sticky_session.rst <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- fab73ee Update locale_sticky_session.rst
The ts-loader major version must map to the webpack major version: TypeStrong/ts-loader#748
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes symfony#9690). Discussion ---------- Incompatible ts-loader version The ts-loader major version must map to the webpack major version: TypeStrong/ts-loader#748 Since symfony/encore depends on webpack 3, installing latest will produce the error above. Commits ------- 8f2d2f1 Incompatible ts-loader version
This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes symfony#9689). Discussion ---------- Update swiftmailer.rst Adding "command" parameter to sendmail transport. Commits ------- dfe33e3 Minor fixes c9adc2f Update swiftmailer.rst
This PR was squashed before being merged into the 2.7 branch (closes symfony#9542). Discussion ---------- [Form] Removed Integer scale option Scale option is hardcoded for IntegerType. These changes result from the discussion introduced by symfony/symfony#26734. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 2f61f75 [Form] Removed Integer scale option
I think that `findDefinition` is better than `getDefinition` as it will also look at aliases. I found it myself while migrating from sf < 3.4 to sf >= 3.4. In particular I was following [this](https://symfony.com/doc/current/service_container/3.3-di-changes.html) and at point 2 services managed directly by `CompilerPass` were never founded. Moreover - not related directly to this PR - I'm not sure that this "split" `getDefinition`/`findDefinition`/`getAlias` is really useful, but maybe I don't have the bigger picture. WDYT?
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes symfony#9676). Discussion ---------- Update compiler_passes.rst I think that `findDefinition` is better than `getDefinition` as it will also look at aliases. I found this by myself while migrating from sf < 3.4 to sf >= 3.4. In particular I was following [this](https://symfony.com/doc/current/service_container/3.3-di-changes.html) and at point 2 services managed directly by `CompilerPass` were never founded. Moreover - not related directly to this PR - I'm not sure that this "split" `getDefinition`/`findDefinition`/`getAlias` is really useful, but maybe I don't have the bigger picture. WDYT? PS.: Maybe this edit could be applied not only for sf 4 but also for previous versions? Commits ------- 9b26fce Update compiler_passes.rst
… (javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- Fixed the project creating command for Symfony 3.4 A use on Slack warned us about this issue. Commits ------- 513c4be Fixed the project creating command for Symfony 3.4
* 2.7: [Form] Removed Integer scale option Minor fixes Update swiftmailer.rst
* 2.8: [Form] Removed Integer scale option Minor fixes Update swiftmailer.rst
Change controller method from "index" to "indexAction"
javiereguiluz
approved these changes
Apr 30, 2018
|
Hi @liviubalan! I'm closing this. Your change is valid. But actually, due to an internal merging issue, the problem only appeared in the 3.4 branch by mistake, temporarily. We've fixed that merge issue, which now means that this problem is no longer there :). Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change controller method from "index" to "indexAction"