Update compiler_passes.rst #9676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that `findDefinition` is better than `getDefinition` as it will also look at aliases. I found it myself while migrating from sf < 3.4 to sf >= 3.4. In particular I was following [this](https://symfony.com/doc/current/service_container/3.3-di-changes.html) and at point 2 services managed directly by `CompilerPass` were never founded. Moreover - not related directly to this PR - I'm not sure that this "split" `getDefinition`/`findDefinition`/`getAlias` is really useful, but maybe I don't have the bigger picture. WDYT?
javiereguiluz
added
Status: Reviewed
DependencyInjection
bug
and removed
Status: Needs Review
labels
javiereguiluz
approved these changes
Apr 25, 2018
|
@javiereguiluz Do you thing we should also point it out here? |
|
I'm afraid I don't understand you. Where exactly do you want to do the change? Thanks! |
|
I would let users aware that, when changing services id(s) from dot notation to FQCN, if any of those services are handled by a compiler pass that leverage on |
|
@DonCallisto thanks for explaining it! Let's do that change too then. |
|
I'll do that in the next hours |
DonCallisto
added a commit
to DonCallisto/symfony-docs
that referenced
this pull request
Apr 27, 2018
|
I saw that you made the other related change in a separate pull request, so let's merge this! Thank you. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 27, 2018
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #9676). Discussion ---------- Update compiler_passes.rst I think that `findDefinition` is better than `getDefinition` as it will also look at aliases. I found this by myself while migrating from sf < 3.4 to sf >= 3.4. In particular I was following [this](https://symfony.com/doc/current/service_container/3.3-di-changes.html) and at point 2 services managed directly by `CompilerPass` were never founded. Moreover - not related directly to this PR - I'm not sure that this "split" `getDefinition`/`findDefinition`/`getAlias` is really useful, but maybe I don't have the bigger picture. WDYT? PS.: Maybe this edit could be applied not only for sf 4 but also for previous versions? Commits ------- 9b26fce Update compiler_passes.rst
javiereguiluz
added a commit
that referenced
this pull request
May 21, 2018
This PR was submitted for the 4.0 branch but it was squashed and merged into the 3.4 branch instead (closes #9695). Discussion ---------- Update 3.3-di-changes.rst Related to #9676 (review) Commits ------- bebe9a0 Update 3.3-di-changes.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that
findDefinitionis better thangetDefinitionas it will also look at aliases.I found this by myself while migrating from sf < 3.4 to sf >= 3.4.
In particular I was following this and at point 2 services managed directly by
CompilerPasswere never founded.Moreover - not related directly to this PR - I'm not sure that this "split"
getDefinition/findDefinition/getAliasis really useful, but maybe I don't have the bigger picture.WDYT?
PS.: Maybe this edit could be applied not only for sf 4 but also for previous versions?