Update flex.rst - Add step in migration-process #9350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the step to add 'symfony/symfony' to the `conflict`-section of your composer.json-file. I did not do this until after the step to change your index.php-section. This resulted in a lot of recipe's not being executed since the libraries for that were still installed by `symfony/symfony`.
|
@Zombaya thanks for improving this article. It's one of our most important articles, so we definitely need a lot of people reviewing its contents. I did a minor change to fix some formatting issue (line was too long) but your original contribution was perfect, so thank you and congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Feb 26, 2018
… javiereguiluz) This PR was merged into the 4.0 branch. Discussion ---------- Update flex.rst - Add step in migration-process I added the step to add 'symfony/symfony' to the `conflict`-section of your composer.json-file. I did not do this until after the step to change your `index.php`-section. This resulted in a lot of recipe's not being executed since the libraries for that were still being installed by `symfony/symfony`. Language improvements are welcomed since English is not my mother tongue. Commits ------- 336260c Minor change 67af1e0 Update flex.rst - Add step in migration-process
xabbuh
reviewed
Feb 27, 2018
|
|
||
| "conflict": { | ||
| "symfony/symfony": "*" | ||
| }, |
There was a problem hiding this comment.
I guess this will not be rendered properly as this extra is not a full valid JSON document. What do you think if we used a diff block here instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the step to add 'symfony/symfony' to the
conflict-section of your composer.json-file.I did not do this until after the step to change your
index.php-section. This resulted in a lot of recipe's not being executed since the libraries for that were still being installed bysymfony/symfony.Language improvements are welcomed since English is not my mother tongue.