Skip to content

Commit 9bbe977

Browse files
committed
Merge branch '2.8' into 3.4
* 2.8: Tweak wording in Upgrading a Patch Version Reword the explanation about HTTP exceptions added documentation for author tag management be more clear about child form to be themed fix FormError access in Twig template Be consistent how we write "core team" Added a note about using the security checker independently Use "children" property instead of "child" Update web_server_configuration.rst Updated a Twig example
2 parents 0bbefb5 + 92c8616 commit 9bbe977

File tree

9 files changed

+31
-18
lines changed

9 files changed

+31
-18
lines changed

contributing/code/core_team.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ All the Symfony Core members are long-time contributors with solid technical
99
expertise and they have demonstrated a strong commitment to drive the project
1010
forward.
1111

12-
This document states the rules that govern the Symfony Core team. These rules
12+
This document states the rules that govern the Symfony core team. These rules
1313
are effective upon publication of this document and all Symfony Core members
1414
must adhere to said rules and protocol.
1515

@@ -121,7 +121,7 @@ Active Core Members
121121
Former Core Members
122122
~~~~~~~~~~~~~~~~~~~
123123

124-
They are no longer part of the Core Team, but we are very grateful for all their
124+
They are no longer part of the core team, but we are very grateful for all their
125125
Symfony contributions:
126126

127127
* **Bernhard Schussek** (`webmozart`_);

contributing/code/security.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ Reporting a Security Issue
1111
If you think that you have found a security issue in Symfony, don't use the
1212
bug tracker and don't publish it publicly. Instead, all security issues must
1313
be sent to **security [at] symfony.com**. Emails sent to this address are
14-
forwarded to the Symfony core-team private mailing-list.
14+
forwarded to the Symfony core team private mailing-list.
1515

1616
Resolving Process
1717
-----------------
1818

1919
For each report, we first try to confirm the vulnerability. When it is
20-
confirmed, the core-team works on a solution following these steps:
20+
confirmed, the core team works on a solution following these steps:
2121

2222
#. Send an acknowledgement to the reporter;
2323
#. Work on a patch;

contributing/code/standards.rst

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,12 @@ Documentation
260260
* The ``@package`` and ``@subpackage`` annotations are not used;
261261

262262
* Don't inline PHPDoc blocks, even when they contain just one tag (e.g. don't
263-
put ``/** {@inheritdoc} */`` in a single line).
263+
put ``/** {@inheritdoc} */`` in a single line);
264+
265+
* When adding a new class or when making significant changes to an existing class,
266+
an ``@author`` tag with personal contact information may be added, or expanded.
267+
Please note it is possible to have the personal contact information updated or
268+
removed per request to the doc:`core team </contributing/code/core_team>`.
264269

265270
License
266271
~~~~~~~

controller.rst

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -409,9 +409,12 @@ method is just a shortcut to create a special
409409
:class:`Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException`
410410
object, which ultimately triggers a 404 HTTP response inside Symfony.
411411

412-
Of course, you're free to throw any ``Exception`` class in your controller -
413-
Symfony will automatically return a 500 HTTP response code::
412+
If you throw an exception that extends or is an instance of
413+
:class:`Symfony\\Component\\HttpKernel\\Exception\\HttpException`, Symfony will
414+
use the appropriate HTTP status code. Otherwise, the response will have a 500
415+
HTTP status code::
414416

417+
// this exception ultimately generates a 500 status error
415418
throw new \Exception('Something went wrong!');
416419

417420
In every case, an error page is shown to the end user and a full debug

form/form_customization.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ You can also apply a form theme to a specific child of your form:
385385

386386
.. code-block:: html+twig
387387

388-
{% form_theme form.child 'form/fields.html.twig' %}
388+
{% form_theme form.a_child_form 'form/fields.html.twig' %}
389389

390390
This is useful when you want to have a custom theme for a nested form that's
391391
different than the one of your main form. Just specify both your themes:
@@ -394,7 +394,7 @@ different than the one of your main form. Just specify both your themes:
394394

395395
{% form_theme form 'form/fields.html.twig' %}
396396

397-
{% form_theme form.child 'form/fields_child.html.twig' %}
397+
{% form_theme form.a_child_form 'form/fields_child.html.twig' %}
398398

399399
Form Theming in PHP
400400
-------------------

security/security_checker.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,12 @@ FriendsOfPHP organization.
2929
To enable the ``security:check`` command, make sure the
3030
`SensioDistributionBundle`_ is installed and enabled in your application.
3131

32+
.. tip::
33+
34+
The security checker is also available as an independent console application
35+
and distributed as a PHAR file so you can use it in any PHP application.
36+
Check out the `Security Checker repository`_ for more details.
37+
3238
.. _`security advisories database`: https://github.com/FriendsOfPHP/security-advisories
3339
.. _`SensioDistributionBundle`: https://github.com/sensiolabs/SensioDistributionBundle
40+
.. _`Security Checker repository`: https://github.com/sensiolabs/security-checker

setup/upgrade_patch.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ update.
2121
.. tip::
2222

2323
It is recommended to update to a new patch version as soon as possible, as
24-
important bugs and security leaks may be fixed in these new releases.
24+
important bugs and security vulnerabilities may be fixed in these new
25+
releases.
2526

2627
.. include:: /setup/_update_all_packages.rst.inc

setup/web_server_configuration.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ listen on. Each pool can also be run under a different UID and GID:
153153
group = www-data
154154
155155
; use a unix domain socket
156-
listen = /var/run/php7.1-fpm.sock
156+
listen = /var/run/php/php7.1-fpm.sock
157157
158158
; or listen on a TCP socket
159159
listen = 127.0.0.1:9000
@@ -251,7 +251,7 @@ instead:
251251

252252
.. code-block:: apache
253253
254-
FastCgiExternalServer /usr/lib/cgi-bin/php7-fcgi -socket /var/run/php7.1-fpm.sock -pass-header Authorization
254+
FastCgiExternalServer /usr/lib/cgi-bin/php7-fcgi -socket /var/run/php/php7.1-fpm.sock -pass-header Authorization
255255
256256
.. _web-server-nginx:
257257

@@ -274,7 +274,7 @@ The **minimum configuration** to get your application running under Nginx is:
274274
# This rule should only be placed on your development environment
275275
# In production, don't include this and don't deploy app_dev.php or config.php
276276
location ~ ^/(app_dev|config)\.php(/|$) {
277-
fastcgi_pass unix:/run/php/php7.1-fpm.sock;
277+
fastcgi_pass unix:/var/run/php/php7.1-fpm.sock;
278278
fastcgi_split_path_info ^(.+\.php)(/.*)$;
279279
include fastcgi_params;
280280
# When you are using symlinks to link the document root to the
@@ -289,7 +289,7 @@ The **minimum configuration** to get your application running under Nginx is:
289289
}
290290
# PROD
291291
location ~ ^/app\.php(/|$) {
292-
fastcgi_pass unix:/run/php/php7.1-fpm.sock;
292+
fastcgi_pass unix:/var/run/php/php7.1-fpm.sock;
293293
fastcgi_split_path_info ^(.+\.php)(/.*)$;
294294
include fastcgi_params;
295295
# When you are using symlinks to link the document root to the

validation/severity.rst

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,7 @@ so that the severity is added as an additional HTML class:
148148
{%- if errors|length > 0 -%}
149149
<ul>
150150
{%- for error in errors -%}
151-
{% if error.constraint.payload.severity is defined %}
152-
{% set severity = error.constraint.payload.severity %}
153-
{% endif %}
154-
<li{% if severity is defined %} class="{{ severity }}"{% endif %}>{{ error.message }}</li>
151+
<li class="{{ error.cause.constraint.payload.severity ?? '' }}">{{ error.message }}</li>
155152
{%- endfor -%}
156153
</ul>
157154
{%- endif -%}

0 commit comments

Comments
 (0)