Gh3334 2 #3338
Gh3334 2 #3338
Conversation
Results from the query should be skipped if they are already in the ISet distinction thus if distinction.Add is false. Currently, they are only added if they have been there before. Signed-off-by: csharper2010 <csharper2010@googlemail.com>
Update master
Results from the query should be skipped if they are already in the ISet distinction thus if distinction.Add is false. Currently, they are only added if they have been there before. Signed-off-by: csharper2010 <csharper2010@googlemail.com>
Results from the query should be skipped if they are already in the ISet distinction thus if distinction.Add is false. Currently, they are only added if they have been there before. Signed-off-by: csharper2010 <csharper2010@googlemail.com>
Convert EntityJoin to FROM_FRAGMENT only for first element Adjust comment in HqlSqlWalker before adding an element without Parent to the tree and use AppendFromElement instead of direct AddChild
| if (fromElement.IsImplied) | ||
| fromElement.JoinSequence.SetUseThetaStyle(true); |
There was a problem hiding this comment.
| if (fromElement.IsImplied) | |
| fromElement.JoinSequence.SetUseThetaStyle(true); |
This hack should no longer be needed if it's a proper fix.
There was a problem hiding this comment.
Unexpected results. Some tests are failed but only added in this PR. So this hack is still required for some reasons I don't understand. But anyway it's definitely a better fix for #3334.
There was a problem hiding this comment.
Thanks for your comment (and effort)... I also think, it makes some things more explicit but does not fully eliminate the need for hacks.
I was experimenting also with removing the need for the if (elem.Parent == null)-Hack but not yet successful. Quite complex this thing.
There was a problem hiding this comment.
I probably OK with keeping it for now. But this PR causes some troubles with MySql on old tests. It needs to be investigated.
|
Replaced by #3369. |
Now I had some time to work on a cleaner solution for #3334 which would make the pull request #3335 obsolete.
The change makes things explicit instead of working around trying to guess the kind of situation we are in.