Skip to content

Obvious bug in two HQLQueryPlan classes with distinction Set #2614

Closed
@csharper2010

Description

@csharper2010

We have a system still running with an old version of NHibernate and I've found a bug when experimenting with current release of NHibernate:

When the needsLimit variable is true in PerformList or PerformListAsync, the Limit is done in memory. To detect duplicates, there's an ISet distinction. In current code, the items are skipped if they can be added to the distinction set but that means they have not yet been added to the combinedResults list. It must be the other way round.

I'll try to prepare a PR.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions