Skip to content

Use inner join instead of implicit join for implied entity joins #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 21, 2022
Merged

Use inner join instead of implicit join for implied entity joins #2990

merged 11 commits into from
Jul 21, 2022

Conversation

bahusoid
Copy link
Member

Should be safe with table group join support

@bahusoid bahusoid changed the title Use inner join instead of implicit join for implied entity joins WIP Use inner join instead of implicit join for implied entity joins Jan 14, 2022
@bahusoid bahusoid changed the title WIP Use inner join instead of implicit join for implied entity joins Use inner join instead of implicit join for implied entity joins Jan 16, 2022
hazzik
hazzik reviewed Jan 17, 2022
View reviewed changes
bahusoid
bahusoid commented Jan 17, 2022
View reviewed changes
fredericDelaporte
fredericDelaporte reviewed May 8, 2022
View reviewed changes
@fredericDelaporte fredericDelaporte added this to the next minor milestone May 8, 2022
@hazzik hazzik enabled auto-merge (squash) July 20, 2022 22:42
@hazzik hazzik merged commit 6017fdc into nhibernate:master Jul 21, 2022
@NecatiMeral NecatiMeral mentioned this pull request Oct 19, 2022
Closed
@bahusoid bahusoid mentioned this pull request Jun 21, 2023
Closed
bahusoid added a commit to csharper2010/nhibernate-core that referenced this pull request Jun 27, 2023
@bahusoid
Try removing hack added in nhibernate#2990 (see 32fdfec)
df73331
bahusoid added a commit to bahusoid/nhibernate-core that referenced this pull request Jun 27, 2023
@bahusoid
Revert "Try removing hack added in nhibernate#2990 (see 32fdfec)"
4c54380 
This reverts commit df73331.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

@fredericDelaporte fredericDelaporte fredericDelaporte left review comments

Assignees
No one assigned
Labels
c: Core p: Minor r: Fixed t: Improvement
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@bahusoid @hazzik @fredericDelaporte