Fix questionable subquery case

bahusoid · bahusoid · commit 32fdfec3d9db · 2022-01-17T11:38:18.000+02:00
diff --git a/src/NHibernate/Hql/Ast/ANTLR/HqlSqlWalker.cs b/src/NHibernate/Hql/Ast/ANTLR/HqlSqlWalker.cs
@@ -759,7 +759,12 @@ void CreateFromJoinElement(
 
 				if (fromElement.Parent == null)
 				{
+					// Most likely means association join is used in invalid context
+					// I.e. in subquery: from EntityA a where exists (from EntityB join a.Assocation)  
+					// Maybe we should throw exception instead
 					fromElement.FromClause.AddChild(fromElement);
+					if (fromElement.IsImplied)
+						fromElement.JoinSequence.SetUseThetaStyle(true);
 				}
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -759,7 +759,12 @@ void CreateFromJoinElement(`
`759`	`759`
`760`	`760`	`if (fromElement.Parent == null)`
`761`	`761`	`{`
	`762`	`+ // Most likely means association join is used in invalid context`
	`763`	`+ // I.e. in subquery: from EntityA a where exists (from EntityB join a.Assocation)`
	`764`	`+ // Maybe we should throw exception instead`
`762`	`765`	`fromElement.FromClause.AddChild(fromElement);`
	`766`	`+ if (fromElement.IsImplied)`
	`767`	`+ fromElement.JoinSequence.SetUseThetaStyle(true);`
`763`	`768`	`}`
`764`	`769`	`}`
`765`	`770`