PHPLIB-1506 Import `mongodb/builder` #1381

GromNaN · 2024-09-09T10:39:51Z

Import files from https://github.com/mongodb/mongo-php-builder
Add replace rule in composer.json
Add a GitHub Action to validate the generated files are up-to-date

…ical field names (mongodb#9) Numerical field names can't be used with named argument, because even if they comes from an array unpacking, the numerical keys are recalculated as a sequence: https://3v4l.org/Gj7jC Everywhere a query is expected, an single array can be passed instead of the variadic arguments. * Tuned the accepted types for field query * Fixed CS (newline after if) in generated code

…odb#3)

* Use BSON round-trip to normalize pipelines for comparison * Use Canonical Extended JSON * Fix $regex comparison

* Add first,firstN,last,lastN operators and tests * Add tests on $first and $last

* Add $all and $elemMatch query operator tests * Accept a single Query operator in $elemMatch * Remove variadic argument for $elemMatch operator to prevent ambiquity

$eq $gt $gte $in $lt $lte $ne $nin

https://www.mongodb.com/docs/manual/reference/operator/query/#logical $and $not $nor $or

* PHPLIB-1335 Add tests on Element Query Operators * Make $type query operator variadic

* PHPLIB-1337 Add tests on Geospatial Query Operators * Fix nested $geometry

* PHPLIB-1273: Improve $switch syntax * Restore previously deleted encoding type in schema * Introduce dedicated interface for branches in $switch * Remove optional parameter in encodeAsObject * Use case operator throughout tests

Bumps [ramsey/composer-install](https://github.com/ramsey/composer-install) from 2.2.0 to 3.0.0. - [Release notes](https://github.com/ramsey/composer-install/releases) - [Commits](ramsey/composer-install@2.2.0...3.0.0) --- updated-dependencies: - dependency-name: ramsey/composer-install dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Allow to merge an array of stages into a pipeline * Improve types * Add test to create pipeline from array

alcaeus

Reviewed the tooling changes, but did not review all the config and generator logic. I trust you copied that over from the builder project without changes. Just have a couple of minor comments, but in general this looks good to go.

composer.json

.github/workflows/generator.yml

alcaeus

Minor comment regarding fetch-depth, but LGTM!

.github/workflows/generator.yml

alcaeus and others added 30 commits October 13, 2023 14:24

Initial commit

1979b84

Add composer package config

68cf384

Add git config files

29d1705

Chore: Enable Issue Template (mongodb#2)

a52d35e

Create experimental builder (mongodb#1)

cf5b119

PHPLIB-1282 Add factories for system variables (mongodb#5)

9d46af7

Fix Javascript type & other PHP types (mongodb#4)

d526ab8

PHPLIB-1265 Reject $ in variable and field path (mongodb#7)

dd0a913

Use final class for factory methods (mongodb#10)

f9dd4fb

PHPLIB-1271 Add tests from the documentation (mongodb#6)

49e266d

Validate duplicate operators are not used in CombinedFieldQuery (mong…

9a8ad5b

…odb#3)

Expand accepted types for field queries (mongodb#11)

6f260f9

Use BSON round-trip to normalize pipelines for comparison (mongodb#13)

d8898ce

* Use BSON round-trip to normalize pipelines for comparison * Use Canonical Extended JSON * Fix $regex comparison

Add script to help convert JS to Yaml (mongodb#15)

0bedc20

Add first, firstN, last, lastN operators and tests (mongodb#14)

a939aa0

* Add first,firstN,last,lastN operators and tests * Add tests on $first and $last

Reduce CI matrix as we don't use MongoDB server (mongodb#16)

29807ed

Add $all and $elemMatch field query operator tests (mongodb#17)

48353b4

* Add $all and $elemMatch query operator tests * Accept a single Query operator in $elemMatch * Remove variadic argument for $elemMatch operator to prevent ambiquity

Various improvements (mongodb#19)

b0886f8

PHPLIB-1333 Add tests on Comparison Query Operators (mongodb#20)

919c4e6

$eq $gt $gte $in $lt $lte $ne $nin

PHPLIB-1334 Add tests on Logical Query Operators (mongodb#21)

4176b5a

https://www.mongodb.com/docs/manual/reference/operator/query/#logical $and $not $nor $or

PHPLIB-1343 Add tests on Array Expression Operators (mongodb#22)

5e8b98a

PHPLIB-1344 Add tests on Bitwise Operators (mongodb#26)

7b3e2ca

PHPLIB-1345 Add tests on Boolean Expression Operators (mongodb#27)

cd27d8d

PHPLIB-1346 Add tests on Comparison Expression Operators (mongodb#28)

3caabb0

PHPLIB-1336 Add tests on Evaluation Query Operators (mongodb#24)

320cc26

PHPLIB-1335 Add tests on Element Query Operators (mongodb#23)

f665eb3

* PHPLIB-1335 Add tests on Element Query Operators * Make $type query operator variadic

PHPLIB-1337 Add tests on Geospatial Query Operators (mongodb#25)

118184d

* PHPLIB-1337 Add tests on Geospatial Query Operators * Fix nested $geometry

PHPLIB-1347 Add tests on Conditional Expression Operators (mongodb#30)

7deb802

PHPLIB-1349 Add tests on Data Size Operators (mongodb#31)

abe57b5

alcaeus and others added 13 commits February 2, 2024 13:28

Add tests for $search and $searchMeta stages (mongodb#61)

040833d

PHPLIB-1273: Improve $switch syntax (mongodb#62)

ceac70d

* PHPLIB-1273: Improve $switch syntax * Restore previously deleted encoding type in schema * Introduce dedicated interface for branches in $switch * Remove optional parameter in encodeAsObject * Use case operator throughout tests

PHPLIB-1381 PHPLIB-1269 Add enum for Sort and TimeUnit (mongodb#63)

63dd036

Fix links

0622bb2

Add fluent builder for Laravel (mongodb#67)

12d951c

Fix MongoDB namespace for InvalidArgumentException (mongodb#68)

fe8f353

Allow to merge an array of stages into a pipeline (mongodb#57)

7c3375d

* Allow to merge an array of stages into a pipeline * Improve types * Add test to create pipeline from array

Add merge-up action (mongodb#69)

aa4f34c

Fix accepted stage type in FluentFactoryTrait (mongodb#71)

6bc447f

Merge branch 'builder' into PHPLIB-1506

2be9ad2

Remove composer constraints already imposed by the main package

bc7618d

Skip Pedentry method sort for generated files

eafad05

GromNaN marked this pull request as ready for review September 9, 2024 12:14

GromNaN requested a review from a team as a code owner September 9, 2024 12:14

GromNaN requested a review from alcaeus September 9, 2024 12:14

GromNaN marked this pull request as draft September 9, 2024 12:17

GromNaN force-pushed the PHPLIB-1506 branch from 2a19b2a to 131dfd7 Compare September 9, 2024 13:06

GromNaN marked this pull request as ready for review September 9, 2024 13:27

alcaeus reviewed Sep 9, 2024

View reviewed changes

composer.json Outdated Show resolved Hide resolved

.github/workflows/generator.yml Outdated Show resolved Hide resolved

.github/workflows/generator.yml Outdated Show resolved Hide resolved

GromNaN force-pushed the PHPLIB-1506 branch from 033f3ed to 644c76d Compare September 9, 2024 14:13

GromNaN requested a review from alcaeus September 9, 2024 14:15

alcaeus approved these changes Sep 9, 2024

View reviewed changes

.github/workflows/generator.yml Outdated Show resolved Hide resolved

GromNaN added 3 commits September 9, 2024 17:09

Replace composer package mongodb/builder

4e66bbc

Check generated files are up-to-date

7a19e9c

Exclude rector.php from the artifact

17d2ba8

GromNaN force-pushed the PHPLIB-1506 branch from 644c76d to 17d2ba8 Compare September 9, 2024 15:10

GromNaN enabled auto-merge September 9, 2024 15:10

GromNaN merged commit e5e6b61 into mongodb:master Sep 9, 2024
30 checks passed

GromNaN deleted the PHPLIB-1506 branch September 9, 2024 16:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PHPLIB-1506 Import `mongodb/builder` #1381

PHPLIB-1506 Import `mongodb/builder` #1381

Uh oh!

GromNaN commented Sep 9, 2024 •

edited

Loading

Uh oh!

alcaeus left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alcaeus left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PHPLIB-1506 Import mongodb/builder #1381

PHPLIB-1506 Import mongodb/builder #1381

Uh oh!

Conversation

GromNaN commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alcaeus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alcaeus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PHPLIB-1506 Import `mongodb/builder` #1381

PHPLIB-1506 Import `mongodb/builder` #1381

GromNaN commented Sep 9, 2024 •

edited

Loading