Fixed PHPLIB-108: Library relies on BSON being a vendor prefix, while our vendor should be MongoDB #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to wait until PHPC-309 is implemented and released, since we'll also need to bump the ext-mongo dependency. |
derickr
force-pushed
the
issue108-vendor-prefix
branch
2 times, most recently
from
03ff930 to
c10f2e2
Compare
| * Internal helper for running a command | ||
| * @internal | ||
| */ | ||
| final protected function _runCommand($dbname, array $cmd, ReadPreference $rp = null) |
There was a problem hiding this comment.
That wasn't me... NFC where it came from.
… our vendor should be MongoDB
derickr
force-pushed
the
issue108-vendor-prefix
branch
from
c10f2e2 to
be1df64
Compare
|
Rebased and merged in #22. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-108