PHPLIB-58: CRUD spec functional tests #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jmikola
commented
Mar 17, 2015
jmikola
commented
- https://jira.mongodb.org/browse/PHPLIB-58
- https://jira.mongodb.org/browse/PHPLIB-86
- https://jira.mongodb.org/browse/PHPLIB-91
- https://jira.mongodb.org/browse/PHPLIB-92
- https://jira.mongodb.org/browse/PHPLIB-93
- https://jira.mongodb.org/browse/PHPLIB-95
- https://jira.mongodb.org/browse/PHPLIB-96
- https://jira.mongodb.org/browse/PHPLIB-97
- https://jira.mongodb.org/browse/PHPLIB-98
jmikola
force-pushed
the
crud-tests
branch
2 times, most recently
from
c6f0b33 to
0112b46
Compare
|
Depends on #6. Once that is completed and merged, this PR should be rebased and resumed. |
jmikola
force-pushed
the
crud-tests
branch
4 times, most recently
from
d1e1e6f to
cb62bea
Compare
jmikola
changed the title
jmikola
force-pushed
the
crud-tests
branch
8 times, most recently
from
07f34e7 to
9d3aa44
Compare
jmikola
force-pushed
the
crud-tests
branch
2 times, most recently
from
b2ae1c2 to
a872c15
Compare
Older servers may return floats.
Earlier server versions incorrectly return an empty document instead of null. Thankfully, we can detect this edge case given the command result and input options.
This adds intelligent detection for the useCursor option's default value. Additionally, server 2.4 does not support any of the aggregate command options of newer servers, so we must not specify default values. The array_map() conversion for inline aggregation results is not ideal, but we can revisit that in PHPLIB-100.
nModified is not provided for legacy write ops, so we should not check for it. Once PHPC-278 is implemented, we can change these assertions to check for null exactly.
We need to account for differing service names between 2.4 and 2.6+.
This should avoid hanging test builds if mongod fails to start.
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Apr 30, 2015
GromNaN
added a commit
to GromNaN/mongo-php-library
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.