PHPLIB-118: Fix compatibility with extension's BSON typemaps #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And we need to use assertEquals as assertSame means it needs to be the same internal object
| @@ -29,9 +29,9 @@ public function testFindOne() | |||
| 'sort' => array('x' => -1), | |||
| ); | |||
|
|
|||
| $expected = array('_id' => 3, 'x' => 33); | |||
| $expected = (object) array('_id' => 3, 'x' => 33); | |||
There was a problem hiding this comment.
This is fine for now. I opened PHPLIB-113 to track creation of a typeMap option for findOne().
|
LGTM. This will fail until PHPC 0.7.0 is released. |
jmikola
changed the title
jmikola
added a commit
that referenced
this pull request
Aug 26, 2015
|
Manually merged and rebased in 81477df. I did come across a segfault in PHPLIB-117, which I'll look into later in the sprint. |
GromNaN
added a commit
to GromNaN/mongo-php-library
that referenced
this pull request
Sep 9, 2024
* PHPLIB-1335 Add tests on Element Query Operators * Make $type query operator variadic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-118