Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

fix: prepare for enabling Ivy #642

Merged
merged 1 commit into from
Oct 3, 2019
Merged

fix: prepare for enabling Ivy #642

merged 1 commit into from
Oct 3, 2019

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Oct 3, 2019 •
edited
Loading

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or weren't appropriate

What is the current behavior?

Issue Number:
N/A

What is the new behavior?

Other information

There is one remaining issue blocking the app from building with Ivy:
_MatTabLinkBase needs the @Directive() treatment i.e.

@Directive({
  // TODO(crisbeto): this selector can be removed when we update to Angular 9.0.
  selector: 'do-not-use-abstract-mat-tab-link-base'
}

@crisbeto is fixing it in angular/components#17282.

@Splaktar
fix: prepare for enabling Ivy
05db7e9 
remove use of AsyncPipe with `*ngFor`
- due to angular/angular#31371
remove deprecated `@angular/http` from StackBlitz dependencies
remove out of date `.angular-cli.json` from StackBlitz templates
- it's unclear that moving to the new `angular.json` format is viable
remove unneeded polyfills from StackBlitz templates
@Splaktar Splaktar requested a review from jelbourn October 3, 2019 10:50
@Splaktar Splaktar self-assigned this Oct 3, 2019
Splaktar
Splaktar commented Oct 3, 2019
View reviewed changes
src/app/shared/version-picker/version-picker.html
@@ -3,7 +3,7 @@
<mat-icon>arrow_drop_down</mat-icon>
</button>
<mat-menu #versionPicker="matMenu">
<button mat-menu-item *ngFor="let version of docVersions | async"
<button mat-menu-item *ngFor="let version of docVersions"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AsyncPipe removed due to the interaction of types defined for NgForOf and AsyncPipe (tracked in angular/angular#31371).

Alternatives were to type it as Observable<any> or disable one of strictNullChecks, enableIvy, or fullTemplateTypeCheck.
Reproduction and more details at: https://github.com/Splaktar/ngfor-asyncpipe-ivy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this workaround may work:
https://github.com/angular/angular/pull/32980/files?file-filters%5B%5D=.html#diff-986a7d69debab319598e3a2e92ea615dR24

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it does. Will update in a follow up PR.

@Splaktar Splaktar requested a review from devversion October 3, 2019 10:54
@Splaktar
Copy link
Contributor Author

Splaktar commented Oct 3, 2019

Going to verify the StackBlitz changes on the dev instance.

I also got another idea to try for allowing the use of the AsyncPipe with *ngFor.

jelbourn
jelbourn approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit f538ebc into master Oct 3, 2019
@Splaktar Splaktar deleted the prepare-for-ivy branch October 3, 2019 20:41
Splaktar added a commit that referenced this pull request Oct 4, 2019
@Splaktar
fix(stack-blitz): add more configuration files to the template
ee97960 
allow the exported/downloaded project from StackBlitz to be functional
- move files into /src and /src/app to match a normal configuration
rename Stackblitz to StackBlitz
use StackBlitz logo to launch examples
use a relative URL for downloading `versions.json`
update Ivy fix for VersionPicker
log errors during app bootstrap in StackBlitz
switch StackBlitz examples to SCSS
fix lint warnings in deploy script
add ignores for Firebase

Fixes #623. Fixes #629. Relates to #642.
@Splaktar Splaktar mentioned this pull request Oct 4, 2019
Closed
2 tasks
Splaktar added a commit that referenced this pull request Oct 5, 2019
@Splaktar
fix(stack-blitz): add more configuration files to the template
790106e 
allow the exported/downloaded project from StackBlitz to be functional
- move files into /src and /src/app to match a normal configuration
rename Stackblitz to StackBlitz
use StackBlitz logo to launch examples
use a relative URL for downloading `versions.json`
update Ivy fix for VersionPicker
log errors during app bootstrap in StackBlitz
switch StackBlitz examples to SCSS
fix lint warnings in deploy script
add ignores for Firebase

Fixes #623. Fixes #629. Relates to #642.
jelbourn pushed a commit that referenced this pull request Oct 7, 2019
@Splaktar @jelbourn
feat: update to 9.0.0-next.x and enable Ivy rendering engine (#645)
051363f 
* fix(stack-blitz): add more configuration files to the template

allow the exported/downloaded project from StackBlitz to be functional
- move files into /src and /src/app to match a normal configuration
rename Stackblitz to StackBlitz
use StackBlitz logo to launch examples
use a relative URL for downloading `versions.json`
update Ivy fix for VersionPicker
log errors during app bootstrap in StackBlitz
switch StackBlitz examples to SCSS
fix lint warnings in deploy script
add ignores for Firebase

Fixes #623. Fixes #629. Relates to #642.

* migrate workspace for @angular/core@9.0.0-beta
Decorates all declared undecorated provider classes with @Injectable

* feat: update to 9.0.0-next.x and enable Ivy rendering engine

add 9.0.0-next.0 to versions list
- point it to material2-docs-dev for now

* fix(ci): update docker image to latest CircleCI NodeJS LTS

the prior version used `yarn@1.10.1`
- @angular-devkit/build-angular@0.900.0-next.8 throws an error
  - Expected version ">= 1.13.0". Got "1.10.1"

* refactor(tools): convert deploy script from npm to yarn

re-enable Angular CLI's build-optimizer
Splaktar added a commit that referenced this pull request Oct 7, 2019
@Splaktar
fix: prepare for enabling Ivy (#642)
d8939ac 
remove use of AsyncPipe with `*ngFor`
- due to angular/angular#31371
remove deprecated `@angular/http` from StackBlitz dependencies
remove out of date `.angular-cli.json` from StackBlitz templates
- it's unclear that moving to the new `angular.json` format is viable
remove unneeded polyfills from StackBlitz templates
Splaktar added a commit that referenced this pull request Oct 7, 2019
@Splaktar
fix(stack-blitz): add more configuration files to the template
6b5d0bb 
allow the exported/downloaded project from StackBlitz to be functional
- move files into /src and /src/app to match a normal configuration
rename Stackblitz to StackBlitz
use StackBlitz logo to launch examples
use a relative URL for downloading `versions.json`
update Ivy fix for VersionPicker
log errors during app bootstrap in StackBlitz
switch StackBlitz examples to SCSS
fix lint warnings in deploy script
add ignores for Firebase

Fixes #623. Fixes #629. Relates to #642.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@Splaktar Splaktar

Labels
cla: yes infrastructure P2: required refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Splaktar @jelbourn @googlebot