fix(tabs): avoid Ivy template type checking errors in tab link #17282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up from angular#17228. Adds a directive annotation to the `_MatTabLinkBase` because it was overlooked the last time around.
crisbeto
added
P1
googlebot
added
the
cla: yes
devversion
approved these changes
Oct 3, 2019
| @@ -62,6 +62,7 @@ import {MatPaginatedTabHeader} from './paginated-tab-header'; | |||
| _MatTabNavBase as any, | |||
| _MatTabBodyBase as any, | |||
| _MatTabHeaderBase as any, | |||
| _MatTabLinkBase as any, | |||
There was a problem hiding this comment.
I think we only need any if the class is actually abstract. But it's not a big deal here.
devversion
added
pr: lgtm
action: merge
2 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #17228. Adds a directive annotation to the
_MatTabLinkBasebecause it was overlooked the last time around.